Skip to content

feat: [EXT-3440] add app actions #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2022
Merged

feat: [EXT-3440] add app actions #1189

merged 3 commits into from
Feb 3, 2022
+622 −0

Conversation

Jwhiles
Copy link
Contributor

@Jwhiles Jwhiles commented Jan 31, 2022

Summary

Description

Motivation and Context

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

Sorry, something went wrong.

@Jwhiles Jwhiles marked this pull request as ready for review February 1, 2022 10:50
@Jwhiles Jwhiles requested a review from shikaan February 3, 2022 08:50
shikaan
shikaan approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@shikaan shikaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is the call part a followup?

@Jwhiles
Copy link
Contributor Author

Jwhiles commented Feb 3, 2022

Looks good to me. Is the call part a followup?

sure is :)

@Jwhiles Jwhiles merged commit 90d812c into master Feb 3, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

🎉 This PR is included in version 7.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 3, 2022
@marcolink marcolink deleted the ext-3440 branch October 6, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikaan shikaan

@andipaetzold andipaetzold

@colomolo colomolo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jwhiles @shikaan