{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":62296222,"defaultBranch":"5.x","name":"manager-bundle","ownerLogin":"contao","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-06-30T09:03:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1206136?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716543504.0","currentOid":""},"activityList":{"items":[{"before":"364cc7e338d488e3b41c09011e3d8f53ea2edd59","after":"4748cfdcc0d823322a9d964b93295ec6018712ad","ref":"refs/heads/5.x","pushedAt":"2024-06-06T11:54:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update the Transifex config files","shortMessageHtmlLink":"Update the Transifex config files"}},{"before":"364cc7e338d488e3b41c09011e3d8f53ea2edd59","after":"017e0ece4a43a3f358c3ccc0a92c1a08b5511399","ref":"refs/heads/5.3","pushedAt":"2024-06-06T07:59:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Rework the messenger integration (see #7253)\n\nDescription\n-----------\n\nFixes https://github.com/contao/contao/issues/7251\r\n\r\n- All the Messenger magic is gone, we now always use the Doctrine queue and all messages are always sent to the queue.\r\n- Everything that used the `SyncTransport` before is now automatically delayed to the `kernel.terminate` event providing an advantage for all users (that have access to `fastcgi_finish_request()`), not only the ones that have the cronjob configured.\r\n- Logic spread across 4 classes is now centralized in 1 🥳 \r\n- It fixes the `You cannot call ack() on the Messenger SyncTransport.` no matter the grace period because the transport configuration does not change anymore.\r\n- The grace period has been adjusted to 10 minutes and is now also configurable\r\n\r\nI've split deleting the old logic and the new in two commits so that it's easier to review.\r\n\r\nRemarks:\r\n\r\n- I decided to not create separate `*Listener` classes because they would all be one-liners forwarding to the `WebWorker` service. Now, all the magic is part of the `WebWorker` which makes it way easier to understand and see what's going on. I know we have `*Listener` classes for almost everything else but I strongly suggest to not do that in this case. It also makes removing the one single service from the container super easy in case no transport is configured to use the web worker (`core-bundle` standalone default).\n\nCommits\n-------\n\n7a8e8ff3 Removed existing auto fallback worker logic\n9d6f0b9b New implementation\nb9af0733 Adjust new implementation\n39a3363e Started writing some of the most complex unit tests I have ever written\n5dfa70ac Adjust grace period to 10 minutes\n7c1d7b54 The actual tests that took me forever...\n565da075 Made grace period configurable and renamed the service\nc9976c09 Adjust config\nc8625244 Some more tests\n8534605f Improve the tests\na3cc5c8d Remove debug statement\nfe68fd87 Docs\ndc68bceb Exclude Symfony Clock from the GlobalStateWatcher\n5d2580c2 Use a different logger approach\n1f9061ee Make phpstan happy\n22b11c06 Apply suggestions from code review\nb35e33f3 Cleanup for phpstan\n4d3e30a0 Forgot to commit the phpstan-ignore line","shortMessageHtmlLink":"Rework the messenger integration (see #7253)"}},{"before":"13b614acb765f906b91fed03f448e026960876de","after":"364cc7e338d488e3b41c09011e3d8f53ea2edd59","ref":"refs/heads/5.x","pushedAt":"2024-05-31T15:18:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #7256)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\n115efe59 Update and run the tools\ne9ac6891 Use @phpstan-ignore instead of @phpstan-ignore-next-line\n0040a128 Make PHPStan 1.11 the minimum version","shortMessageHtmlLink":"Update and run the tools (see #7256)"}},{"before":"13b614acb765f906b91fed03f448e026960876de","after":"364cc7e338d488e3b41c09011e3d8f53ea2edd59","ref":"refs/heads/5.3","pushedAt":"2024-05-31T11:32:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #7256)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\n115efe59 Update and run the tools\ne9ac6891 Use @phpstan-ignore instead of @phpstan-ignore-next-line\n0040a128 Make PHPStan 1.11 the minimum version","shortMessageHtmlLink":"Update and run the tools (see #7256)"}},{"before":"21bf70813f1118864888f809161ecd383a4fcc60","after":"50ed0d8ff60c8760fcee41a19828612f8864c463","ref":"refs/heads/4.13","pushedAt":"2024-05-10T09:46:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update the CI workflows (see #7207)\n\nDescription\r\n-----------\r\n\r\n\r\n\r\nCommits\r\n-------\r\n\r\n5884a342 Update the CI workflows\r\nb2206fdd Use codecov-action@v4\r\n61867d8d Fix the ci.yml file\r\nac0c6dfe Fix the reverse order tests","shortMessageHtmlLink":"Update the CI workflows (see #7207)"}},{"before":"10beb510587d0a5f5f9fb755f4bb7c842df854d0","after":"13b614acb765f906b91fed03f448e026960876de","ref":"refs/heads/5.x","pushedAt":"2024-04-16T11:01:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #7119)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\n0302dc06 Update and run the tools","shortMessageHtmlLink":"Update and run the tools (see #7119)"}},{"before":"10beb510587d0a5f5f9fb755f4bb7c842df854d0","after":"13b614acb765f906b91fed03f448e026960876de","ref":"refs/heads/5.3","pushedAt":"2024-04-16T10:04:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #7119)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\n0302dc06 Update and run the tools","shortMessageHtmlLink":"Update and run the tools (see #7119)"}},{"before":"15a0d2538552d999b6860d50007acfa661d4301d","after":"10beb510587d0a5f5f9fb755f4bb7c842df854d0","ref":"refs/heads/5.x","pushedAt":"2024-04-11T16:44:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Move the config files that reference paths into the root directory (see #7103)\n\nDescription\r\n-----------\r\n\r\n\r\n\r\nCommits\r\n-------\r\n\r\n7cd24daf Move the config files that reference paths into the root directory\r\nab0319b5 Run the tools\r\n40962860 Fix the CI file","shortMessageHtmlLink":"Move the config files that reference paths into the root directory (s…"}},{"before":"15a0d2538552d999b6860d50007acfa661d4301d","after":"10beb510587d0a5f5f9fb755f4bb7c842df854d0","ref":"refs/heads/5.3","pushedAt":"2024-04-10T11:02:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Move the config files that reference paths into the root directory (see #7103)\n\nDescription\r\n-----------\r\n\r\n\r\n\r\nCommits\r\n-------\r\n\r\n7cd24daf Move the config files that reference paths into the root directory\r\nab0319b5 Run the tools\r\n40962860 Fix the CI file","shortMessageHtmlLink":"Move the config files that reference paths into the root directory (s…"}},{"before":"02fa8715916094d1b2b7b727e5df0d68a1bee8c2","after":"15a0d2538552d999b6860d50007acfa661d4301d","ref":"refs/heads/5.x","pushedAt":"2024-03-21T16:34:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Set the email message priority to \"high\" (see #6968)\n\nDescription\n-----------\n\nI think we've discussed that e-mails should be treated with priority on the queue but seems like we forgot to adjust the default config? 😊\n\nCommits\n-------\n\neeae8423 Adjust e-mail message priority to high","shortMessageHtmlLink":"Set the email message priority to \"high\" (see #6968)"}},{"before":"02fa8715916094d1b2b7b727e5df0d68a1bee8c2","after":"15a0d2538552d999b6860d50007acfa661d4301d","ref":"refs/heads/5.3","pushedAt":"2024-03-11T14:01:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Set the email message priority to \"high\" (see #6968)\n\nDescription\n-----------\n\nI think we've discussed that e-mails should be treated with priority on the queue but seems like we forgot to adjust the default config? 😊\n\nCommits\n-------\n\neeae8423 Adjust e-mail message priority to high","shortMessageHtmlLink":"Set the email message priority to \"high\" (see #6968)"}},{"before":"145d13c63c29b65bfae242d890e5bdab2294cad6","after":"02fa8715916094d1b2b7b727e5df0d68a1bee8c2","ref":"refs/heads/5.x","pushedAt":"2024-03-08T09:13:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Fix the `dotenv:dump` command (see #6969)\n\nDescription\n-----------\n\nThis will dynamically dump `APP_ENV=jwt` into the `.env.local.php` file, if the `.env` and `.env.local` do not contain `APP_ENV`.\n\nCommits\n-------\n\nedf61526 Fix the environment dump command","shortMessageHtmlLink":"Fix the <code>dotenv:dump</code> command (see #6969)"}},{"before":"969ce933ae692aba15fcb3066f20957deef7b43f","after":"02fa8715916094d1b2b7b727e5df0d68a1bee8c2","ref":"refs/heads/5.3","pushedAt":"2024-03-08T07:15:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Fix the `dotenv:dump` command (see #6969)\n\nDescription\n-----------\n\nThis will dynamically dump `APP_ENV=jwt` into the `.env.local.php` file, if the `.env` and `.env.local` do not contain `APP_ENV`.\n\nCommits\n-------\n\nedf61526 Fix the environment dump command","shortMessageHtmlLink":"Fix the <code>dotenv:dump</code> command (see #6969)"}},{"before":"16dccbf0acef81274f00362c3493a1cf003448ea","after":"969ce933ae692aba15fcb3066f20957deef7b43f","ref":"refs/heads/5.3","pushedAt":"2024-03-05T10:16:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Make sure the `.env.local.php` is loaded correctly (see #6962)\n\nDescription\n-----------\n\nThis fixes a few issues:\r\n\r\n- if you had a `.env.prod.local` for example, this was never loaded because of the missing second `self::loadEnv()` call\r\n- the `.env.local.php` was never correctly loaded either\r\n- we now use `Dotenv::populate()` which correctly populates all variables instead of our manual old code\r\n- Passing `false` as argument to `Dotenv` is deprecated, this is not needed anymore\n\nCommits\n-------\n\ne83d9ad6 Make sure the .env.local.php is correctly loaded","shortMessageHtmlLink":"Make sure the <code>.env.local.php</code> is loaded correctly (see #6962)"}},{"before":"145d13c63c29b65bfae242d890e5bdab2294cad6","after":"16dccbf0acef81274f00362c3493a1cf003448ea","ref":"refs/heads/5.3","pushedAt":"2024-02-29T14:28:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Register the `dotenv:dump` command by default in the Contao managed edition (see #6954)\n\nDescription\n-----------\n\nWe know that Contao is mostly deployed on hosting providers that do not support real environment variables but we also rely on the `Dotenv` component ourselves for e.g. Mailer configuration etc.\r\n\r\nFor performance reasons, on those systems I would like to run `dotenv:dump` so Symfony dumps `.env.local.php` which is way faster as it can be cached in OPCode cache. Of course, you cannot change `.env.local` anymore without also updating that file then. But you will have to add `dotenv:dump` to your deploy chain manually anyway so you'll know that - it doesn't happen just like that.\r\n\r\nHowever, the command is not registered by default in Symfony even though it has been around since Symfony 5.4. See https://github.com/symfony/symfony/pull/42610. This means that right now I have to add this configuration to every ME but given the fact of our hosting provider situation, I think this qualifies to be a good default.\r\nAgain, it just makes sure the command is around, you'll still have to use it yourself.\n\nCommits\n-------\n\n5f181332 Register the dotenv:dump command by default in the Contao ME\n11337abd Adjust service name\nf236946e Update manager-bundle/config/services.yaml","shortMessageHtmlLink":"Register the <code>dotenv:dump</code> command by default in the Contao managed e…"}},{"before":"384670314dbb2abb2bc40d2ad376edce745b5568","after":"145d13c63c29b65bfae242d890e5bdab2294cad6","ref":"refs/heads/5.x","pushedAt":"2024-02-23T17:56:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #6918)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\nbb7ca0f5 Update and run the tools","shortMessageHtmlLink":"Update and run the tools (see #6918)"}},{"before":"384670314dbb2abb2bc40d2ad376edce745b5568","after":"145d13c63c29b65bfae242d890e5bdab2294cad6","ref":"refs/heads/5.3","pushedAt":"2024-02-21T11:48:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #6918)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\nbb7ca0f5 Update and run the tools","shortMessageHtmlLink":"Update and run the tools (see #6918)"}},{"before":"c5b416a3105e605becfc799ae98c24fe64233306","after":"384670314dbb2abb2bc40d2ad376edce745b5568","ref":"refs/heads/5.x","pushedAt":"2024-02-20T10:45:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Remove unnecessary inline `@var` annotations (see #6902)\n\nDescription\n-----------\n\nWe generally use inline `@var` annotations for PhpStorm and PHPStan.\r\n\r\nPhpStorm now understands a lot more than when we added the inline `@var` annotations, so I was able to remove many of them. And PHPStan prefers more robust ways to ensure type safety anyway, so I replaced the PHPStan-related annotations with return type extensions where possible.\n\nCommits\n-------\n\n3bfda662 Remove unnecessary inline @var annotations in the calendar bundle\n77582d7d Remove unnecessary inline @var annotations in the comments bundle\n52339d87 Remove unnecessary inline @var annotations in the FAQ bundle\nf6a81d73 Remove unnecessary inline @var annotations in the listing bundle\n4790c503 Remove unnecessary inline @var annotations in the manager bundle\nf6dd8095 Remove unnecessary inline @var annotations in the news bundle\n2ae60b1a Remove unnecessary inline @var annotations in the newsletter bundle\n41cc39d2 Remove unnecessary inline @var annotations in the core bundle\n35b70b4a Fix the @template annotation of the ResponseContext class\nc3d3038f Fix a call in the Model class\nf4a29eca Fix the reverse PHPUnit tests\nad050a81 Use findByPk() instead of getRelated()\n32a4ce41 Final touch-ups","shortMessageHtmlLink":"Remove unnecessary inline <code>@var</code> annotations (see #6902)"}},{"before":"c5b416a3105e605becfc799ae98c24fe64233306","after":"384670314dbb2abb2bc40d2ad376edce745b5568","ref":"refs/heads/5.3","pushedAt":"2024-02-20T08:24:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Remove unnecessary inline `@var` annotations (see #6902)\n\nDescription\n-----------\n\nWe generally use inline `@var` annotations for PhpStorm and PHPStan.\r\n\r\nPhpStorm now understands a lot more than when we added the inline `@var` annotations, so I was able to remove many of them. And PHPStan prefers more robust ways to ensure type safety anyway, so I replaced the PHPStan-related annotations with return type extensions where possible.\n\nCommits\n-------\n\n3bfda662 Remove unnecessary inline @var annotations in the calendar bundle\n77582d7d Remove unnecessary inline @var annotations in the comments bundle\n52339d87 Remove unnecessary inline @var annotations in the FAQ bundle\nf6a81d73 Remove unnecessary inline @var annotations in the listing bundle\n4790c503 Remove unnecessary inline @var annotations in the manager bundle\nf6dd8095 Remove unnecessary inline @var annotations in the news bundle\n2ae60b1a Remove unnecessary inline @var annotations in the newsletter bundle\n41cc39d2 Remove unnecessary inline @var annotations in the core bundle\n35b70b4a Fix the @template annotation of the ResponseContext class\nc3d3038f Fix a call in the Model class\nf4a29eca Fix the reverse PHPUnit tests\nad050a81 Use findByPk() instead of getRelated()\n32a4ce41 Final touch-ups","shortMessageHtmlLink":"Remove unnecessary inline <code>@var</code> annotations (see #6902)"}},{"before":"70b2e5efedaffccb64f3fe5c4168b26077ac61e0","after":"c5b416a3105e605becfc799ae98c24fe64233306","ref":"refs/heads/5.x","pushedAt":"2024-02-16T14:29:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Improve logging of request parameters (see #6900)\n\nDescription\n-----------\n\nUnfortunately, I noticed two flaws in https://github.com/contao/contao/pull/6533\r\n\r\n1. the logged `request_uri` is currently **not** absolute, which is potentially problematic in our CMS that supports multi-domains\r\n2. the logged `request_method` is the _actual_ method, which ignores any _HTTP Method Overrides_. I think it makes more sense to log what our application receives though.\r\n\r\nUnfortunately, neither can be accomplished with any default processor in Symfony or Monolog, so we need our own.\n\nCommits\n-------\n\n1f29c50d Correctly migrate RememberMe table from Contao 4.13\n39e19606 Update core-bundle/src/Migration/Version503/RememberMeMigration.php\n0dcd6145 Improve logging of request parameters\n8f8cb563 Merge remote-tracking branch 'upstream/5.3' into fix/log-uri\n8f64c6fe Added test","shortMessageHtmlLink":"Improve logging of request parameters (see #6900)"}},{"before":"70b2e5efedaffccb64f3fe5c4168b26077ac61e0","after":"c5b416a3105e605becfc799ae98c24fe64233306","ref":"refs/heads/5.3","pushedAt":"2024-02-16T11:01:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Improve logging of request parameters (see #6900)\n\nDescription\n-----------\n\nUnfortunately, I noticed two flaws in https://github.com/contao/contao/pull/6533\r\n\r\n1. the logged `request_uri` is currently **not** absolute, which is potentially problematic in our CMS that supports multi-domains\r\n2. the logged `request_method` is the _actual_ method, which ignores any _HTTP Method Overrides_. I think it makes more sense to log what our application receives though.\r\n\r\nUnfortunately, neither can be accomplished with any default processor in Symfony or Monolog, so we need our own.\n\nCommits\n-------\n\n1f29c50d Correctly migrate RememberMe table from Contao 4.13\n39e19606 Update core-bundle/src/Migration/Version503/RememberMeMigration.php\n0dcd6145 Improve logging of request parameters\n8f8cb563 Merge remote-tracking branch 'upstream/5.3' into fix/log-uri\n8f64c6fe Added test","shortMessageHtmlLink":"Improve logging of request parameters (see #6900)"}},{"before":"e1022143fdbe95006f84be77c6f04cdbdb5f0246","after":"70b2e5efedaffccb64f3fe5c4168b26077ac61e0","ref":"refs/heads/5.x","pushedAt":"2024-02-12T15:18:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Make the commands lazy again (see #6882)\n\nDescription\n-----------\n\nFixes #6881\n\nCommits\n-------\n\nf0c67fa3 Make the commands lazy again","shortMessageHtmlLink":"Make the commands lazy again (see #6882)"}},{"before":"da25591b2ad0fd3422a99e7c5c265a789f82ac88","after":"70b2e5efedaffccb64f3fe5c4168b26077ac61e0","ref":"refs/heads/5.3","pushedAt":"2024-02-12T09:35:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Make the commands lazy again (see #6882)\n\nDescription\n-----------\n\nFixes #6881\n\nCommits\n-------\n\nf0c67fa3 Make the commands lazy again","shortMessageHtmlLink":"Make the commands lazy again (see #6882)"}},{"before":"e1022143fdbe95006f84be77c6f04cdbdb5f0246","after":"da25591b2ad0fd3422a99e7c5c265a789f82ac88","ref":"refs/heads/5.3","pushedAt":"2024-02-09T09:43:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Update and run the tools (see #6873)\n\nDescription\n-----------\n\n\n\nCommits\n-------\n\n2745c0e1 Update and run the tools","shortMessageHtmlLink":"Update and run the tools (see #6873)"}},{"before":"d16ca77aa327f4db3a5a66623dfc36a02a65bf0d","after":"e1022143fdbe95006f84be77c6f04cdbdb5f0246","ref":"refs/heads/5.x","pushedAt":"2024-02-01T14:21:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Correctly handle denied access in the firewall (see #6805)\n\nDescription\n-----------\n\nThis now fixes and improves a lot of things 🙈 \r\n\r\n1. Fixes the authentication system to correctly render the Contao login page even if the current route is not a Contao page (e.g. a custom controller)\r\n1. Fixes the `ContaoLoginAuthenticator` from rendering the wrong page for login (if the user is not fully authenticated).\r\n2. ~Fixes the remember me authentication system~ (see https://github.com/contao/contao/pull/6815)\r\n3. Adds an `AccessDeniedHandler` to render the 403 page via the firewall exception handler\r\n4. Correctly enforces fully authentication for changing personal data, changing the user password and configuring two-factor authentication\r\n5. Removes the ExceptionConverter and PrettyErrorScreen from rendering 401 and 403 pages, because these are rendered by the firewall\r\n\r\nThere are two \"behaviour changes\" I can think of\r\n-  obviously the fully-authentication works and is now enforces as described in point 4\r\n- If no 401 or 403 pages are configured in root page, we now render the generic error (through the pretty error screen listener) instead of the generic Symfony 401/403 message. Since we are in Contao frontend scope, I think that should be fine.\r\n\r\n### TODO:\r\n- [x] ~Needs a migration for existing RememberMe tokens (the migration tool cannot migrate binary data to string value because the binary data is null-padded and therefore longer than the new string field).~\n\nCommits\n-------\n\n9cba1e82 Correctly handle denied access in firewall\n5d88701a Handle full authentication in login and user modules\n8ffa5206 Fix the rememberme functionality\n45b29166 CS & Tests\nec43cfc6 CS & Tests\n272f0ad2 Update the security configs\n9dc8d9e9 Improved re-authentication in login module\na4f72645 Tests\nb807be1a Update core-bundle/contao/languages/en/default.xlf\ne917497a Do not treat the \"please verify your identity\" message as error\n7e07f1ce Handle re-authentication on the redirect page\nd9d05c38 Correctly handle request object\n90d5b704 Correctly handle request object\n\nCo-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>","shortMessageHtmlLink":"Correctly handle denied access in the firewall (see #6805)"}},{"before":"8826f7be8fde3e021a76f036dd6bd005b760df6f","after":"e1022143fdbe95006f84be77c6f04cdbdb5f0246","ref":"refs/heads/5.3","pushedAt":"2024-02-01T09:56:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Correctly handle denied access in the firewall (see #6805)\n\nDescription\n-----------\n\nThis now fixes and improves a lot of things 🙈 \r\n\r\n1. Fixes the authentication system to correctly render the Contao login page even if the current route is not a Contao page (e.g. a custom controller)\r\n1. Fixes the `ContaoLoginAuthenticator` from rendering the wrong page for login (if the user is not fully authenticated).\r\n2. ~Fixes the remember me authentication system~ (see https://github.com/contao/contao/pull/6815)\r\n3. Adds an `AccessDeniedHandler` to render the 403 page via the firewall exception handler\r\n4. Correctly enforces fully authentication for changing personal data, changing the user password and configuring two-factor authentication\r\n5. Removes the ExceptionConverter and PrettyErrorScreen from rendering 401 and 403 pages, because these are rendered by the firewall\r\n\r\nThere are two \"behaviour changes\" I can think of\r\n-  obviously the fully-authentication works and is now enforces as described in point 4\r\n- If no 401 or 403 pages are configured in root page, we now render the generic error (through the pretty error screen listener) instead of the generic Symfony 401/403 message. Since we are in Contao frontend scope, I think that should be fine.\r\n\r\n### TODO:\r\n- [x] ~Needs a migration for existing RememberMe tokens (the migration tool cannot migrate binary data to string value because the binary data is null-padded and therefore longer than the new string field).~\n\nCommits\n-------\n\n9cba1e82 Correctly handle denied access in firewall\n5d88701a Handle full authentication in login and user modules\n8ffa5206 Fix the rememberme functionality\n45b29166 CS & Tests\nec43cfc6 CS & Tests\n272f0ad2 Update the security configs\n9dc8d9e9 Improved re-authentication in login module\na4f72645 Tests\nb807be1a Update core-bundle/contao/languages/en/default.xlf\ne917497a Do not treat the \"please verify your identity\" message as error\n7e07f1ce Handle re-authentication on the redirect page\nd9d05c38 Correctly handle request object\n90d5b704 Correctly handle request object\n\nCo-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>","shortMessageHtmlLink":"Correctly handle denied access in the firewall (see #6805)"}},{"before":"d16ca77aa327f4db3a5a66623dfc36a02a65bf0d","after":"8826f7be8fde3e021a76f036dd6bd005b760df6f","ref":"refs/heads/5.3","pushedAt":"2024-01-30T14:46:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Drop the custom \"remember me\" implementation (see #6815)\n\nDescription\n-----------\n\nManually tested this locally:\r\n - `contao:migrate` correctly generates the schema\r\n - the cookie name is still the same\r\n - deleting the session cookie logs me back in through rememberme\r\n - if I manually log out, the remember me cookie and database get cleared\n\nCommits\n-------\n\ne3bc9d66 Drop the custom RememberMe implementation\n07ee23f6 Drop the custom RememberMe implementation\ne152b718 Also adjust the security.yaml file of the functional tests\n9befc66c Revert \"Also adjust the security.yaml file of the functional tests\"\n04997ac8 Added migration\nb57eafa8 Fixed YAML\n\nCo-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>","shortMessageHtmlLink":"Drop the custom \"remember me\" implementation (see #6815)"}},{"before":"f392e18751c9588c75512a456f28842bfac502cb","after":"d16ca77aa327f4db3a5a66623dfc36a02a65bf0d","ref":"refs/heads/5.x","pushedAt":"2024-01-25T17:15:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Use auto-configuration where possible (see #6743)\n\nDescription\n-----------\n\nI‘m adding the PR to save the work, however, the configuration is still scattered and not fully visible anywhere. I wish we wouldn‘t use auto-configuration at all, then the config files would be the single source of truth.\n\nCommits\n-------\n\n63e4959a Show the relative path to the config files instead of just the name\nac21392f Check the tags\nc43c1e76 Do not register the PickerProviderInterface for autoconfiguration in …\n9db0db03 Use auto-configuration where possible\n055a01c6 Fix the reverse order tests\nb925a196 Fine-tuning","shortMessageHtmlLink":"Use auto-configuration where possible (see #6743)"}},{"before":"f392e18751c9588c75512a456f28842bfac502cb","after":"d16ca77aa327f4db3a5a66623dfc36a02a65bf0d","ref":"refs/heads/5.3","pushedAt":"2024-01-25T10:31:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Use auto-configuration where possible (see #6743)\n\nDescription\n-----------\n\nI‘m adding the PR to save the work, however, the configuration is still scattered and not fully visible anywhere. I wish we wouldn‘t use auto-configuration at all, then the config files would be the single source of truth.\n\nCommits\n-------\n\n63e4959a Show the relative path to the config files instead of just the name\nac21392f Check the tags\nc43c1e76 Do not register the PickerProviderInterface for autoconfiguration in …\n9db0db03 Use auto-configuration where possible\n055a01c6 Fix the reverse order tests\nb925a196 Fine-tuning","shortMessageHtmlLink":"Use auto-configuration where possible (see #6743)"}},{"before":null,"after":"f392e18751c9588c75512a456f28842bfac502cb","ref":"refs/heads/5.3","pushedAt":"2024-01-18T11:40:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"leofeyer","name":"Leo Feyer","path":"/leofeyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1192057?s=80&v=4"},"commit":{"message":"Merge branch '5.2' into 5.x\n\n# Conflicts:\n#\tCHANGELOG.md\n#\tCONTRIBUTORS.md","shortMessageHtmlLink":"Merge branch '5.2' into 5.x"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXiFkMwA","startCursor":null,"endCursor":null}},"title":"Activity · contao/manager-bundle"}