Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DeauthenticatedEvent #475

Closed
aschempp opened this issue May 6, 2019 · 6 comments · Fixed by #5788
Closed

Use DeauthenticatedEvent #475

aschempp opened this issue May 6, 2019 · 6 comments · Fixed by #5788
Assignees
@bytehead
Labels
feature

Comments

@aschempp
Copy link
Member

aschempp commented May 6, 2019

symfony/symfony#31138

Should we use this to delete all related tl_remember_me items?
@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label May 8, 2019
@leofeyer
Copy link
Member

leofeyer commented May 9, 2019

Also see symfony/symfony#31172

@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label May 9, 2019
@leofeyer
Copy link
Member

It seems this has been fixed in symfony/symfony#34671. Can we close our issue then?

@aschempp
Copy link
Member Author

aschempp commented Oct 5, 2020

not really. Symfony removes the cookie now, but we should still remove the entry from tl_remember_me?

@leofeyer
Copy link
Member

So how do we proceed here?

@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Sep 22, 2022
@leofeyer
Copy link
Member

@bytehead Could you please take a look at this?

@bytehead bytehead self-assigned this Nov 24, 2022
@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Jan 12, 2023
@bytehead bytehead mentioned this issue Feb 20, 2023
Merged
@bytehead bytehead linked a pull request Feb 20, 2023 that will close this issue
Add the TokenDeauthenticatedListener #5788
Merged
@bytehead
Copy link
Member

Close in favor of #5788

leofeyer added a commit that referenced this issue Mar 13, 2023
@bytehead @leofeyer
Add the TokenDeauthenticatedListener (see #5788)
2c16abe 
Description
-----------

Implements #475 

Commits
-------

070250c Add TokenDeauthenticatedListener
3455097 Add missing test
e455ea7 No PHP 8 features please
a0e7278 CS
1f675a6 Merge branch '5.1' into feature/deauthenticated-event
00e46ad Merge branch '5.1' into feature/deauthenticated-event
4e3a8cc CS

Co-authored-by: Leo Feyer <1192057+leofeyer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bytehead bytehead

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the TokenDeauthenticatedListener bytehead/contao
3 participants
@bytehead @aschempp @leofeyer