Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session isn’t started inside ESI requests if it was startet in the main request #470

Closed
ausi opened this issue May 3, 2019 · 4 comments

Comments

@ausi
Copy link
Member

ausi commented May 3, 2019

If the main request starts the session and there is no previous session (there is no session cookie in the request) then inside ESI requests (e.g. {{request_token}}) both $session->isStarted() && $request->hasPreviousSession() returns false.

@Toflar
Copy link
Member

Toflar commented May 3, 2019

Ping @aschempp

@aschempp
Copy link
Member

aschempp commented May 6, 2019

what Symfony version are you on? Maybe related to symfony/symfony#30620

@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label May 8, 2019
@leofeyer
Copy link
Member

leofeyer commented May 9, 2019

As discussed in Mumble on May 9th, @ausi will further debug this issue.

@ausi ausi closed this as completed Jun 6, 2019
@ausi
Copy link
Member Author

ausi commented Jun 6, 2019

Not having access to a just started session inside the ESI request seems to be correct, so this is not a bug. See symfony/symfony#31078 (comment)

The related issue with the CSRF token will be solved differently.

@ausi ausi removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Jun 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants