Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output of contao:install-web-dir is hardcoded #4066

Closed
ameotoko opened this issue Feb 3, 2022 · 0 comments · Fixed by #4269
Closed

Output of contao:install-web-dir is hardcoded #4066

ameotoko opened this issue Feb 3, 2022 · 0 comments · Fixed by #4269
Labels
bug
Milestone
4.13

Comments

@ameotoko
Copy link
Contributor

ameotoko commented Feb 3, 2022

Affected version(s)

4.x

Description

contao:install-web-dir does not report the actual path it has worked on, but a hardcoded value instead. It has been hardcoded in all the 4.x branches, it was just renamed from web to public in #3084. Which is why I caught it – because I updated existing project that already uses web.

The command correctly detects web if it exists, or creates public if it doesn't, but it always reports back the latter:

Added the public/.htaccess file.
Added the public/preview.php file.
Added the public/app.php file.
Added the public/index.php file.

This gives the first impression, that something is broken, but it's not 😄.

Slack thread: https://contao.slack.com/archives/CK9GW3ARL/p1641131560142600

Also, the command never receives a configured %contao.web_dir% when executed directly on CLI, but that's probably other can of worms.
@leofeyer leofeyer added this to the 4.12 milestone Feb 4, 2022
@leofeyer leofeyer modified the milestones: 4.12, 4.13 Feb 18, 2022
@leofeyer leofeyer mentioned this issue Mar 14, 2022
Merged
@leofeyer leofeyer linked a pull request Mar 14, 2022 that will close this issue
Use the correct web dir in the InstallWebDirCommand #4269
Merged
leofeyer added a commit that referenced this issue Mar 14, 2022
@leofeyer
Use the correct web dir in the InstallWebDirCommand (see #4269)
0ed2c1e 
Description
-----------

Fixes #4066

Commits
-------

1076b2b Use the correct web dir in the InstallWebDirCommand
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging a pull request may close this issue.

Use the correct web dir in the InstallWebDirCommand leofeyer/contao
2 participants
@leofeyer @ameotoko