Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): add builtin JSON tpl #260

Merged
merged 3 commits into from Jul 16, 2022
Merged

feat(generic): add builtin JSON tpl #260

merged 3 commits into from Jul 16, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Jul 16, 2022

This adds some additional functionality to the generic service to make it a bit more useful.

You can now supply the template as json to format the message and title as a simple JSON-object. Combined with the ability to rename the keys in the payload, it should add compatibility with at least a few know services.

ref #256

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #260 (19b1f7b) into main (39c19cb) will increase coverage by 0.10%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   77.85%   77.96%   +0.10%     
==========================================
  Files          96       96              
  Lines        2877     2900      +23     
==========================================
+ Hits         2240     2261      +21     
- Misses        466      467       +1     
- Partials      171      172       +1     
Impacted Files Coverage Δ
pkg/services/generic/generic_config.go 93.54% <ø> (ø)
pkg/services/generic/generic.go 86.66% <89.18%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c19cb...19b1f7b. Read the comment docs.

@piksel piksel merged commit 357c766 into main Jul 16, 2022
@piksel piksel deleted the feat/generic-common-tpl branch July 16, 2022 12:52
@piksel piksel mentioned this pull request Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant