Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord message size fixes #242

Merged
merged 5 commits into from May 21, 2022
Merged

discord message size fixes #242

merged 5 commits into from May 21, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented May 21, 2022

solves two panic conditions when using the discord service:

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #242 (ba99f9e) into main (6dbcb12) will increase coverage by 0.55%.
The diff coverage is 100.00%.

❗ Current head ba99f9e differs from pull request most recent head 616f2c6. Consider uploading reports for the commit 616f2c6 to get more accurate results

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   77.07%   77.63%   +0.55%     
==========================================
  Files          95       95              
  Lines        2844     2857      +13     
==========================================
+ Hits         2192     2218      +26     
+ Misses        473      466       -7     
+ Partials      179      173       -6     
Impacted Files Coverage Δ
pkg/services/discord/discord.go 81.25% <100.00%> (+24.72%) ⬆️
pkg/services/discord/discord_json.go 92.59% <100.00%> (+0.92%) ⬆️
pkg/util/partition_message.go 95.74% <100.00%> (+0.29%) ⬆️
pkg/services/slack/slack_json.go 100.00% <0.00%> (ø)
pkg/services/discord/discord_config.go 88.23% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbcb12...616f2c6. Read the comment docs.

piksel and others added 2 commits May 21, 2022 14:08
@piksel piksel merged commit 6a27056 into main May 21, 2022
@piksel piksel deleted the fix/discord-limits branch May 21, 2022 12:48
@piksel
Copy link
Member Author

piksel commented May 24, 2022

@all-contributors add @justinsteven for bug

@allcontributors
Copy link
Contributor

@piksel

I've put up a pull request to add @justinsteven! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants