Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotify): handle token ending in / #235

Merged
merged 2 commits into from May 22, 2022
Merged

fix(gotify): handle token ending in / #235

merged 2 commits into from May 22, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented May 1, 2022

This fixes a problem in gotify service, where it would not correctly handle a URL with only a token, but ending in /.
It also provides the full error messages as returned by the server upon failure.

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #235 (8976d5b) into main (3261fbf) will increase coverage by 0.85%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   76.85%   77.71%   +0.85%     
==========================================
  Files          95       96       +1     
  Lines        2826     2863      +37     
==========================================
+ Hits         2172     2225      +53     
+ Misses        474      468       -6     
+ Partials      180      170      -10     
Impacted Files Coverage Δ
pkg/services/gotify/gotify_json.go 0.00% <0.00%> (ø)
pkg/services/gotify/gotify.go 85.71% <100.00%> (+8.79%) ⬆️
pkg/services/gotify/gotify_config.go 90.90% <100.00%> (+2.67%) ⬆️
pkg/util/jsonclient/jsonclient.go 71.11% <100.00%> (+0.65%) ⬆️
pkg/util/partition_message.go 90.00% <0.00%> (-5.46%) ⬇️
pkg/util/util.go 100.00% <0.00%> (ø)
pkg/services/slack/slack_json.go 100.00% <0.00%> (ø)
pkg/services/mattermost/mattermost_json.go 100.00% <0.00%> (ø)
pkg/services/discord/discord_json.go 92.59% <0.00%> (+0.92%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3261fbf...8976d5b. Read the comment docs.

@piksel piksel merged commit c91dc3c into main May 22, 2022
@piksel piksel deleted the fix/gotify-tlc branch May 22, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant