Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bark): add bark service #234

Merged
merged 7 commits into from Apr 29, 2022
Merged

feat(bark): add bark service #234

merged 7 commits into from Apr 29, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 29, 2022

Fixes #233

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #234 (c96ef92) into main (d0df652) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   77.26%   76.85%   -0.41%     
==========================================
  Files          85       95      +10     
  Lines        2705     2826     +121     
==========================================
+ Hits         2090     2172      +82     
- Misses        435      474      +39     
  Partials      180      180              
Impacted Files Coverage Δ
pkg/util/util.go 100.00% <ø> (+27.27%) ⬆️
internal/testutils/config.go 100.00% <100.00%> (ø)
internal/testutils/logging.go 100.00% <100.00%> (ø)
internal/testutils/must.go 100.00% <100.00%> (ø)
internal/testutils/service.go 100.00% <100.00%> (ø)
pkg/router/servicemap.go 100.00% <100.00%> (ø)
pkg/services/bark/bark.go 100.00% <100.00%> (ø)
pkg/services/bark/bark_config.go 100.00% <100.00%> (ø)
pkg/services/bark/bark_json.go 100.00% <100.00%> (ø)
internal/testutils/iofaker.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0df652...c96ef92. Read the comment docs.

@piksel piksel merged commit 3261fbf into main Apr 29, 2022
@piksel piksel deleted the feat/bark branch April 29, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bark notification support
1 participant