{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":146918141,"defaultBranch":"main","name":"toolbox","ownerLogin":"containers","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-08-31T16:39:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5874934?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1702984142.0","currentOid":""},"activityList":{"items":[{"before":"74d4fcf00c6ec3d1954a87da60b38fdc5eed7b2d","after":"d8289fb8322f3145128bdc498be26084e5d56134","ref":"refs/heads/main","pushedAt":"2024-05-22T11:58:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"Optimize 'enter' and 'run' for a container getting initialized\n\nCurrently, the 'enter' and 'run' commands poll at one second intervals\nto check if the Toolbx container's entry point has created the\ninitialization stamp file to indicate that the container has been\ninitialized.  This came from the POSIX shell implementation [1], where\nit was relatively easier to poll than to use inotify(7) to monitor the\nfile system.\n\nThe problem with polling is that the interval is always going to be\neither too short and waste resources or too long and cause delays.  The\ncurrent one second interval is sufficiently long to add a noticeable\ndelay to the 'enter' and 'run' commands.\n\nIt will be better to use inotify(7) to monitor the file system, which is\nquite easy to do with the Go implementation, so that the commands can\nproceed as soon as the initialization stamp file is available, instead\nof waiting for the polling interval to pass.\n\nThere's a fallback to polling, as before, when the operating system is\nsuffering from a shortage of resources needed for inotify(7).  This code\npath can be forced through the TOOLBX_RUN_USE_POLLING environment\nvariable for testing.  Setting this environment variable disables some\ncode to ensure that the polling ticker is actually used, because,\notherwise, the race between the creation and detection of the\ninitialization stamp file makes it difficult to test the fallback.\n\n[1] Commit d3e0f3df06d3f5ac\n    https://github.com/containers/toolbox/commit/d3e0f3df06d3f5ac\n    https://github.com/containers/toolbox/pull/305\n\nhttps://github.com/containers/toolbox/issues/1070","shortMessageHtmlLink":"Optimize 'enter' and 'run' for a container getting initialized"}},{"before":"af56286ab2c27368c38f957cb991f91041b5aee7","after":"74d4fcf00c6ec3d1954a87da60b38fdc5eed7b2d","ref":"refs/heads/main","pushedAt":"2024-05-20T09:27:24.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"cmd/run: Optimize 'enter' and 'run' for an already running container\n\nCurrently, the 'enter' and 'run' commands always invoke 'podman start'\neven if the Toolbx container's entry point is already running.  There's\nno need for that.  The commands already invoke 'podman inspect' to find\nout if the org.freedesktop.Flatpak.SessionHelper D-Bus service needs to\nbe started.  Thus, they already have what is needed to find out if the\ncontainer is stopped and 'podman start' is necessary before it can be\nused with 'podman exec', or if it's already running.\n\nThe unconditional 'podman start' invocation was followed by a second\n'podman inspect' invocation to find out if the 'podman start' managed to\nstart the container's entry point.  There's no need for this second\n'podman inspect' either, just like the 'podman start', when it's already\nknown from the first 'podman inspect' that the container is running.\n\nThe extra 'podman start' and 'podman inspect' invocations are\nsufficiently expensive to add a noticeable overhead to the 'enter' and\n'run' commands.  It's common to use a container that's already running,\njust like having multiple terminals within the same working directory,\nand terminal emulation applications like Ptyxis try to make it easier to\ndo so [1].  Therefore, it's worth optimizing this code path.\n\n[1] https://gitlab.gnome.org/chergert/ptyxis\n    https://flathub.org/apps/app.devsuite.Ptyxis\n\nhttps://github.com/containers/toolbox/issues/1070","shortMessageHtmlLink":"cmd/run: Optimize 'enter' and 'run' for an already running container"}},{"before":"ec7eb59bb058c12d44413535445b2795af22814e","after":"af56286ab2c27368c38f957cb991f91041b5aee7","ref":"refs/heads/main","pushedAt":"2024-05-19T22:23:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"cmd/run, test/system: Fix typo\n\nFallout from 238f2451e7d7d54adaf73bc5ec548731df5eb242\n\nhttps://github.com/containers/toolbox/pull/1493","shortMessageHtmlLink":"cmd/run, test/system: Fix typo"}},{"before":"598e998a1438d09897f6173ed4e02d03f2a6ee0e","after":"ec7eb59bb058c12d44413535445b2795af22814e","ref":"refs/heads/main","pushedAt":"2024-05-17T09:29:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"cmd/run, pkg/podman: Make podman.InspectContainer() return a Container\n\nUnmarshal the JSON from 'podman inspect --format json --type container'\ndirectly inside podman.InspectContainer() to confine the details within\nthe podman package.\n\nThe JSON samples for the unit tests were taken using the default Toolbx\ncontainer on versions of Fedora that shipped a specific Podman and\nToolbx version.  This accounts for differences in the JSON caused by\ndifferent major versions of Podman and the way different Toolbx versions\nset up the containers.\n\nOne exception was Fedora 28, which had Podman 1.1.2 and Toolbx 0.0.9,\nwhich was the last Toolbx version before 'toolbox init-container' became\nthe entry point for all Toolbx containers [1].  However, the default\nToolbx image is no longer available from registry.fedoraproject.org.\nHence, the image for Fedora 29 was used.\n\nThe minimum required Podman version is 1.6.4 [2], and the Go\nimplementation has been encouraging users to create containers with\nToolbx version 0.0.17 or newer [3].  The versions used to collect the\nJSON samples for the unit tests were chosen accordingly.  They don't\nexhaustively cover all possible supported and unsupported version\ncombinations, but hopefully enough to be useful.\n\n[1] Commit 8b84b5e4604921fa\n    https://github.com/containers/toolbox/commit/8b84b5e4604921fa\n    https://github.com/debarshiray/toolbox/pull/160\n\n[2] Commit 8e80dd5db1e6f40b\n    https://github.com/containers/toolbox/commit/8e80dd5db1e6f40b\n    https://github.com/containers/toolbox/pull/1253\n\n[3] Commit 238f2451e7d7d54a\n    https://github.com/containers/toolbox/commit/238f2451e7d7d54a\n    https://github.com/containers/toolbox/pull/318\n\nhttps://github.com/containers/toolbox/pull/1490","shortMessageHtmlLink":"cmd/run, pkg/podman: Make podman.InspectContainer() return a Container"}},{"before":"8b4eff2101cde48a7b915e17e90c3167d97a5ccf","after":"598e998a1438d09897f6173ed4e02d03f2a6ee0e","ref":"refs/heads/main","pushedAt":"2024-05-15T19:24:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"pkg/podman: Reorder alphabetically\n\nhttps://github.com/containers/toolbox/pull/1489","shortMessageHtmlLink":"pkg/podman: Reorder alphabetically"}},{"before":"eff9a442820b9d370802e9bc0c167de1baefbd8d","after":"8b4eff2101cde48a7b915e17e90c3167d97a5ccf","ref":"refs/heads/main","pushedAt":"2024-05-13T14:02:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"cmd/run, pkg/podman: Split Inspect() into two for containers and images\n\nIn future, it will be good if podman.Inspect() returned a Container or\nImage object instead of a []map[string]interface{} that the caller has\nto parse.  This is because parsing the []map[string]interface{} involves\ntracking changes in the JSON output by different Podman versions, and\nit's better to limit such details to the podman package.\n\nSplitting podman.Inspect() into two separate functions for containers\nand images is one way of achieving that.\n\nhttps://github.com/containers/toolbox/pull/1487","shortMessageHtmlLink":"cmd/run, pkg/podman: Split Inspect() into two for containers and images"}},{"before":"d0323027e0e423a4f3c14e85fda8f2c4a163583d","after":"eff9a442820b9d370802e9bc0c167de1baefbd8d","ref":"refs/heads/main","pushedAt":"2024-05-13T13:59:09.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Ensure that 'create' can use an image without a name\n\nhttps://github.com/containers/toolbox/pull/1486","shortMessageHtmlLink":"test/system: Ensure that 'create' can use an image without a name"}},{"before":"26640d2f14290cb935b8d7b41ee73ec211416f66","after":"d0323027e0e423a4f3c14e85fda8f2c4a163583d","ref":"refs/heads/main","pushedAt":"2024-05-09T14:05:03.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"cmd/list, pkg/podman: Limit access to the raw 'podman ps' JSON\n\nThis builds on top of commit 56fcb0b4d26adb9c.\n\nThe toolboxContainer type has been renamed to Container and moved into\nthe podman package.\n\nThere is nothing Toolbx specific about the type - it represents any\ncontainer returned by 'podman ps'.  The containers are only later\nfiltered for Toolbx containers.\n\nSecondly, having the Container type inside the podman package makes it\npossible to encapsulate the unmarshalling of the JSON within the package\nwithout exposing the raw JSON to outside consumers.  This is desirable\nbecause the unmarshalling involves tracking changes in the JSON output\nby different Podman versions, and it's better to limit such details to\nthe podman package.\n\nhttps://github.com/containers/toolbox/pull/1485","shortMessageHtmlLink":"cmd/list, pkg/podman: Limit access to the raw 'podman ps' JSON"}},{"before":"9ea89670c6508479be2f9eaa9f71de3812a97b56","after":"26640d2f14290cb935b8d7b41ee73ec211416f66","ref":"refs/heads/main","pushedAt":"2024-05-07T14:05:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Drop unnecessary port configuration from registry container\n\nThe specific port used by the local temporary Docker registry inside the\ncontainer doesn't matter.  The container is running only one service and\nits users only see the corresponding port on the host operating system.\nThe default port within the container is 5000 [1] and there's no reason\nto change it.\n\n[1] https://github.com/distribution/distribution-library-image\n\nhttps://github.com/containers/toolbox/pull/1484","shortMessageHtmlLink":"test/system: Drop unnecessary port configuration from registry container"}},{"before":"6626b11e1565412e411f585657ebe9615ec58cad","after":"9ea89670c6508479be2f9eaa9f71de3812a97b56","ref":"refs/heads/main","pushedAt":"2024-05-02T16:16:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":".zuul: Enable testing on Fedora 40\n\nhttps://github.com/containers/toolbox/pull/1468","shortMessageHtmlLink":".zuul: Enable testing on Fedora 40"}},{"before":"640ca4cf3dc6f8629d6802879258a34cdf2e3f92","after":"6626b11e1565412e411f585657ebe9615ec58cad","ref":"refs/heads/main","pushedAt":"2024-04-30T22:01:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"playbooks: Show the Bats version\n\nAnsible's built-in 'package' module doesn't show any details when\ninstalling the RPMs.  All that can be seen is:\n  TASK [Install RPM packages]\n  fedora-rawhide | changed\n\nTherefore, there's no way to know what version of the packages got\ninstalled.\n\nIn this case, not knowing the Bats version being used by the CI makes it\ndifficult to know why the tests are generating this spew on Fedora\nRawhide [1]:\n  TASK [Run system tests]\n  test/system/libs/helpers.bash: line 7: TEMP_BASE_DIR: readonly variable\n  test/system/libs/helpers.bash: line 8: TEMP_STORAGE_DIR: readonly variable\n  test/system/libs/helpers.bash: line 10: IMAGE_CACHE_DIR: readonly variable\n  test/system/libs/helpers.bash: line 11: ROOTLESS_PODMAN_STORE_DIR: readonly variable\n  test/system/libs/helpers.bash: line 12: ROOTLESS_PODMAN_RUNROOT_DIR: readonly variable\n  test/system/libs/helpers.bash: line 13: PODMAN_STORE_CONFIG_FILE: readonly variable\n  test/system/libs/helpers.bash: line 14: DOCKER_REG_ROOT: readonly variable\n  test/system/libs/helpers.bash: line 15: DOCKER_REG_CERTS_DIR: readonly variable\n  test/system/libs/helpers.bash: line 16: DOCKER_REG_AUTH_DIR: readonly variable\n  test/system/libs/helpers.bash: line 17: DOCKER_REG_URI: readonly variable\n  test/system/libs/helpers.bash: line 18: DOCKER_REG_NAME: readonly variable\n  test/system/libs/helpers.bash: line 21: PODMAN: readonly variable\n  test/system/libs/helpers.bash: line 22: TOOLBX: readonly variable\n  test/system/libs/helpers.bash: line 23: SKOPEO: readonly variable\n  ...\n  fedora-rawhide | 1..340\n\n[1] https://github.com/bats-core/bats-core/pull/904\n\nhttps://github.com/containers/toolbox/pull/1482","shortMessageHtmlLink":"playbooks: Show the Bats version"}},{"before":"e01c1efce526ca3ef492c22607464bc3d0b50fb5","after":"640ca4cf3dc6f8629d6802879258a34cdf2e3f92","ref":"refs/heads/main","pushedAt":"2024-03-14T10:58:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":".github/workflows: Bump actions/checkout from v3 to v4\n\n`checkout@v3` makes use of Node 16, which has reached end of life [1].\n`checkout@v4` makes use of Node 20 instead [2,3].\n\n[1] https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/\n[2] https://github.com/actions/checkout/blob/main/CHANGELOG.md#v400\n[3] https://github.com/actions/checkout/pull/1436\n\nhttps://github.com/containers/toolbox/issues/1459\n\nSigned-off-by: Dominique Polek <dominique.polek@mailbox.org>","shortMessageHtmlLink":".github/workflows: Bump actions/checkout from v3 to v4"}},{"before":"818a22bf80686f36719f79f635ed4e1340be70ed","after":"e01c1efce526ca3ef492c22607464bc3d0b50fb5","ref":"refs/heads/main","pushedAt":"2024-03-06T17:36:48.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"README.md: Move the badges to the end\n\n... to prioritise the introductory text.\n\nhttps://github.com/containers/toolbox/pull/1467","shortMessageHtmlLink":"README.md: Move the badges to the end"}},{"before":"11086cc081a764ae0b24663a6597498e261e7a8d","after":"818a22bf80686f36719f79f635ed4e1340be70ed","ref":"refs/heads/main","pushedAt":"2024-03-02T06:24:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"playbooks/system-test: Avoid running out of storage space (part 2)\n\nThis should have been part of commit 571dc9780bdf9a9e.\n\nhttps://github.com/containers/toolbox/pull/1464","shortMessageHtmlLink":"playbooks/system-test: Avoid running out of storage space (part 2)"}},{"before":"27878880e619c6760e86fc14817918dd0382403a","after":"11086cc081a764ae0b24663a6597498e261e7a8d","ref":"refs/heads/main","pushedAt":"2024-03-01T14:28:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":".github: Drop one \"o\" and rename the project as \"Toolbx\" (part 2)\n\nThe environment variable to explicitly set the path to the toolbox(1)\nbinary was renamed to TOOLBX.\n\nFallout from c3403dae8cb0544ecaa94abdcd5eb3c896851b90\n\nhttps://github.com/containers/toolbox/pull/1463","shortMessageHtmlLink":".github: Drop one \"o\" and rename the project as \"Toolbx\" (part 2)"}},{"before":"e2700786808a3ccf3116e2ed29df625753f4f101","after":"27878880e619c6760e86fc14817918dd0382403a","ref":"refs/heads/main","pushedAt":"2024-03-01T01:08:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"Update copyright notices\n\nhttps://github.com/containers/toolbox/pull/1462","shortMessageHtmlLink":"Update copyright notices"}},{"before":"9d3ae61ed8c5194916e46c425aaa9ce7874fe386","after":"e2700786808a3ccf3116e2ed29df625753f4f101","ref":"refs/heads/main","pushedAt":"2024-02-27T15:36:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"pkg/utils, test/system: Preserve the xterm version\n\nXTerm injects its version into the process running inside it through the\nXTERM_VERSION environment variable [1].  This is used by programs like\nNeovim to detect the terminal features supported by xterm [2,3,4].\n\nThe XTERM_VERSION environment variable is not meant to be set by the\nshell's start-up scripts, but directly by xterm, and hence needs to be\npreserved across the host operating system and Toolbx container.\n\n[1] https://invisible-island.net/xterm/manpage/xterm.html\n\n[2] Neovim commit 3d8e0594e495c42d\n    https://github.com/neovim/neovim/commit/3d8e0594e495c42d\n\n[3] Neovim commit 16300d02c7fbe953\n    https://github.com/neovim/neovim/commit/16300d02c7fbe953\n\n[4] Neovim commit ab7da4c53138768f\n    https://github.com/neovim/neovim/commit/ab7da4c53138768f\n    https://github.com/neovim/neovim/issues/8644\n\nhttps://github.com/containers/toolbox/issues/1449\n\nSigned-off-by: Dominique Polek <dominique.polek@mailbox.org>","shortMessageHtmlLink":"pkg/utils, test/system: Preserve the xterm version"}},{"before":"11f3802f8de3093ea9190a3c87257db4ab88a2b9","after":"9d3ae61ed8c5194916e46c425aaa9ce7874fe386","ref":"refs/heads/main","pushedAt":"2024-02-27T14:51:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Unbreak Podman's downstream Fedora CI (part 2)\n\nThe working directory from which bats(1) is invoked might not be part of\nthe Toolbx container.  eg., Podman's downstream Fedora CI invokes the\ntests as:\n  $ cd /path/to/toolbox/test/system\n  $ bats .\n\n... and it led to [1]:\n  not ok 110 run: Smoke test with true(1)\n  # (from function `assert_output' in file\n      ./libs/bats-assert/src/assert.bash, line 255,\n  #  in test file ./104-run.bats, line 38)\n  #   `assert_output \"\"' failed\n  #\n  # -- output differs --\n  # expected (0 lines):\n  #\n  # actual (3 lines):\n  #   Error: crun: chdir to `/usr/share/toolbox/test/system`: No such\n      file or directory: OCI runtime attempted to invoke a command that\n      was not found\n  #   Error: directory /usr/share/toolbox/test/system not found in\n      container fedora-toolbox-41\n  #   Using /home/testuser instead.\n  # --\n  #\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968\n\nhttps://github.com/containers/toolbox/pull/1457","shortMessageHtmlLink":"test/system: Unbreak Podman's downstream Fedora CI (part 2)"}},{"before":"3ca7e869beb21df698d003637295a519e90fa226","after":"11f3802f8de3093ea9190a3c87257db4ab88a2b9","ref":"refs/heads/main","pushedAt":"2024-02-27T09:45:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"pkg/utils, test/system: Preserve the Konsole version\n\nKonsole injects its version into the process running inside it through\nthe KONSOLE_VERSION environment variable [1].  This is used by programs\nlike Neovim to detect the terminal features supported by Konsole [2].\nThis is just like VTE and its VTE_VERSION environment variable.\n\nThe KONSOLE_VERSION environment variable is not meant to be set by the\nshell's start-up scripts, but directly by Konsole, and hence needs to be\npreserved across the host operating system and Toolbx container.\n\n[1] Konsole commit b0d3d83eca4f523a\n    https://invent.kde.org/utilities/konsole/-/commit/b0d3d83eca4f523a\n    https://phabricator.kde.org/D12621\n    https://bugs.kde.org/show_bug.cgi?id=347323\n\n[2] Neovim commit c16529afa5c8eb03\n    https://github.com/neovim/neovim/commit/c16529afa5c8eb03\n    https://github.com/neovim/neovim/issues/8300\n\nhttps://github.com/containers/toolbox/issues/1449\n\nSigned-off-by: Dominique Polek <dominique.polek@mailbox.org>","shortMessageHtmlLink":"pkg/utils, test/system: Preserve the Konsole version"}},{"before":"616d05319347bba736e5222ee4f017d1adf4b6fb","after":"3ca7e869beb21df698d003637295a519e90fa226","ref":"refs/heads/main","pushedAt":"2024-02-22T08:51:36.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"images/fedora: Add all the iconv converter modules for glibc\n\nCurrently, the glibc package mentions glibc-gconv-extra, which contains\nthe iconv converter modules that are not commonly used, as a weak\ndependency [1].  However, the glibc package is part of the fedora base\nimage, which doesn't include weak dependencies [2], and that leads to\nglibc-gconv-extra going missing.\n\nOnly the images for currently maintained Fedoras (ie., 38 and 39) were\nupdated.\n\n[1] Fedora glibc commit 51ca5d3334c3cd35\n    https://src.fedoraproject.org/rpms/glibc/c/51ca5d3334c3cd35\n    https://src.fedoraproject.org/rpms/glibc/pull-request/36\n    https://bugzilla.redhat.com/show_bug.cgi?id=1812191\n\n[2] fedora-kickstarts commit 1c39c0adb0d44866\n    https://pagure.io/fedora-kickstarts/c/1c39c0adb0d44866\n    https://pagure.io/fedora-kickstarts/pull-request/551\n    https://pagure.io/releng/issue/8530\n\nhttps://github.com/containers/toolbox/pull/1456","shortMessageHtmlLink":"images/fedora: Add all the iconv converter modules for glibc"}},{"before":"6e661376055b84dcd9eab683be6a9ea65ced2349","after":"616d05319347bba736e5222ee4f017d1adf4b6fb","ref":"refs/heads/main","pushedAt":"2024-02-21T12:12:08.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Foxboron","name":"Morten Linderud","path":"/Foxboron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1042946?s=80&v=4"},"commit":{"message":"github/workflows/ubuntu: Unified workflow, use buildah & podman\n\n- Use a unified workflow for both PR & Push jobs\n- Build using buildah & push with podman\n\nSigned-off-by: Timothée Ravier <tim@siosm.fr>","shortMessageHtmlLink":"github/workflows/ubuntu: Unified workflow, use buildah &amp; podman"}},{"before":"6838e9347199e875f9869acd2afa64688161ca11","after":"6e661376055b84dcd9eab683be6a9ea65ced2349","ref":"refs/heads/main","pushedAt":"2024-02-20T01:37:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Limit the scope of temporary files used by a single test\n\nBATS_RUN_TMPDIR is the directory used by Bats for its own internal\ntemporary files, and BATS_TEST_TMPDIR is for creating files unique to\neach test [1].  It's better to limit the scope of the tests' temporary\nfiles as much as possible to avoid unexpected collisions with Bats' own\ninternal temporary files.\n\n[1] https://bats-core.readthedocs.io/en/stable/writing-tests.html\n\nhttps://github.com/containers/toolbox/pull/1452","shortMessageHtmlLink":"test/system: Limit the scope of temporary files used by a single test"}},{"before":"641b04aa837c75153a7ac9ed82934da99f522ee3","after":"6838e9347199e875f9869acd2afa64688161ca11","ref":"refs/heads/main","pushedAt":"2024-02-13T21:51:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Unbreak Podman's downstream Fedora CI\n\nThe paths to bats-assert and bats-support are broken, if bats(1) is\ninvoked from any other location than the parent directory of the 'tests'\ndirectory.  eg., Podman's downstream Fedora CI invokes the tests as:\n  $ cd /path/to/toolbox/test/system\n  $ bats .\n\n... and it led to [1]:\n  1..306\n  # test suite: Set up\n  # Missing dependencies\n  # Forgot to run 'git submodule init' and 'git submodule update' ?\n  # test suite: Tear down\n  not ok 1 setup_suite\n  # (from function `setup_suite' in test file ./setup_suite.bash, line 33)\n  #   `return 1' failed\n  # bats warning: Executed 1 instead of expected 306 tests\n\nFallout from 2c0960660330dc6be6861502988695f9812c475a\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968\n\nhttps://github.com/containers/toolbox/pull/1448","shortMessageHtmlLink":"test/system: Unbreak Podman's downstream Fedora CI"}},{"before":"c3403dae8cb0544ecaa94abdcd5eb3c896851b90","after":"641b04aa837c75153a7ac9ed82934da99f522ee3","ref":"refs/heads/main","pushedAt":"2024-02-09T12:36:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Ensure that process started by 'podman exec' has all groups\n\nCommit 15173f8c25c81244 exposed a bug in crun(1) [1] where the process\nstarted directly by 'podman exec --user ...' inside the Toolbx container\nwould not have the supplementary groups attached to the user by the\nentry point.\n\nThis could be observed by differences in id(1):\n  ⬢$ id\n  uid=1000(user) gid=1000(user) groups=1000(user)\n  ⬢$ id user\n  uid=1000(user) gid=1000(user) groups=1000(user),10(wheel)\n\n... and could be worked around by starting a new session with sudo(8).\n\n[1] crun commit 9effaebb429a1aed\n    https://github.com/containers/crun/commit/9effaebb429a1aed\n    https://github.com/containers/crun/issues/644\n    https://github.com/containers/podman/issues/9986\n\nhttps://github.com/containers/toolbox/issues/608","shortMessageHtmlLink":"test/system: Ensure that process started by 'podman exec' has all groups"}},{"before":"ce66b0b86b0749b8b2005747f3d604d6b8c95638","after":"c3403dae8cb0544ecaa94abdcd5eb3c896851b90","ref":"refs/heads/main","pushedAt":"2024-02-06T19:11:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"Drop one \"o\" and rename the project as \"Toolbx\"\n\nThis is meant to make the project more searchable on the Internet.  More\nand more people have been pointing out that \"toolbox\" is terribly\ndifficult to search for, and it's impossible to find any decent\nInternet real estate by that name.\n\nSome exceptions:\n\n  * The code repository is still https://github.com/containers/toolbox.\n    It will be renamed after giving a heads-up to other contributors.\n\n  * The name of the binary is still 'toolbox'.  The name is embedded\n    into existing Toolbx containers as their entry point, which is bind\n    mounted from the host operating system when the containers are\n    started.  Trivially renaming the binary will prevent these\n    containers from starting.\n\n  * For similar reasons, the TOOLBOX_PATH environment variable is still\n    the same.\n\n  * For similar reasons, the profile.d file to be read by the shell on\n    start-up is still called toolbox.sh.\n\n  * The label used to identify Toolbx containers and images is still\n    called com.github.containers.toolbox.  There are many existing\n    Toolbx containers, and many Toolbx images beyond the control of the\n    Toolbx project that use this label to identity themselves.  Simply\n    renaming the label will prevent these containers and images from\n    being recognized.\n\n  * The names of the built-in Toolbx images still retain the word\n    'toolbox'.  Images under the new name need to be published on the\n    OCI registries and the toolbox(1) binary needs to be taught to\n    handle both old and new names, wherever necessary, for backwards\n    compatibility.\n\n  * The stamp file used to identify Toolbx containers is still called\n    /run/.toolboxenv because it's used by various external programs and\n    users to identify Toolbx containers.\n\n  * The OSC 777 escape sequence to track and preserve the user's current\n    Toolbx container [1] still emits 'toolbox' as the name of the\n    container runtime.  Changing the escape sequence can break terminal\n    emulation applications, like Prompt [2], that consume it.  Hence, it\n    needs to be done carefully.\n\n  * The runtime directories at /run/toolbox, when used as root, and\n    $XDG_RUNTIME_DIR/toolbox, when used rootless, weren't renamed.\n\n    When used as root, /run/toolbox is embedded into existing Toolbx\n    containers as a bind mount from the host.  Trivially renaming the\n    path will prevent these containers from starting.\n\n    Secondly, both these paths are used to synchronize container\n    start-up.  If the paths are trivially renamed, and the toolbox(1)\n    binary is updated and used without stopping all existing containers,\n    then it won't be able to enter containers that were already started.\n    Strictly speaking, this scenario isn't supported, since updates are\n    always expected to be \"offline\" [3].  However, it's worth noting\n    because solving the previous problem might also address this.\n\n  * The configuration file for RPM is still called\n    /usr/lib/rpm/macros.d/macros.toolbox.\n\n[1] https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/17\n\n[2] https://gitlab.gnome.org/chergert/prompt\n\n[3] https://www.freedesktop.org/software/systemd/man/latest/systemd.offline-updates.html\n\nhttps://github.com/containers/toolbox/issues/1399","shortMessageHtmlLink":"Drop one \"o\" and rename the project as \"Toolbx\""}},{"before":"4ca0123943642abf35eef26e33c9a17131dd3f32","after":"ce66b0b86b0749b8b2005747f3d604d6b8c95638","ref":"refs/heads/main","pushedAt":"2024-02-02T19:39:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":".zuul: Try to prevent the CI from timing out on Fedora 38 and 39\n\nWith the recent expansion of the test suite, it's necessary to increase\nthe timeout for the Fedora 38 and 39 nodes to prevent the CI from timing\nout.\n\nhttps://github.com/containers/toolbox/pull/1445","shortMessageHtmlLink":".zuul: Try to prevent the CI from timing out on Fedora 38 and 39"}},{"before":"3092ca5f75c57a518c96107663fe948a53518d0b","after":"4ca0123943642abf35eef26e33c9a17131dd3f32","ref":"refs/heads/main","pushedAt":"2024-02-01T19:59:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"images/fedora/f38: Update missing-docs\n\nOtherwise the image fails to build with:\n  $ podman build images/fedora/f38\n  ...\n  Packages with missing files:\n  libcomps\n  ...\n\nhttps://github.com/containers/toolbox/issues/1351","shortMessageHtmlLink":"images/fedora/f38: Update missing-docs"}},{"before":"037dc293884913be91fc90885d721b96be146584","after":"3092ca5f75c57a518c96107663fe948a53518d0b","ref":"refs/heads/main","pushedAt":"2024-01-25T01:40:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"build: Do not use use auto dependencies for shell completion scripts\n\nIt is difficult for downstream to track dependencies when they are\nautomatic. This results in shell completion scripts not being\ninstalled in packages because builders do not have the right\ndependency. This commit adds meson feature arguments to guard those\ndependencies so that downstream distributions can use\n`-Dauto_features=enabled`.\n\nFor more explanation, see rule #3 of:\nhttps://blogs.gnome.org/mcatanzaro/2022/07/15/best-practices-for-build-options/\n\nhttps://github.com/containers/toolbox/pull/1442\n\nSigned-off-by: Valentin David <me@valentindavid.com>","shortMessageHtmlLink":"build: Do not use use auto dependencies for shell completion scripts"}},{"before":"7463f4bfbe20c0e618e45ae0cc43268da9ed4cff","after":"037dc293884913be91fc90885d721b96be146584","ref":"refs/heads/main","pushedAt":"2024-01-24T22:52:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"debarshiray","name":"Debarshi Ray","path":"/debarshiray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3208107?s=80&v=4"},"commit":{"message":"test/system: Remove stray newline\n\nhttps://github.com/containers/toolbox/pull/1437","shortMessageHtmlLink":"test/system: Remove stray newline"}},{"before":"6dfd2294295a18e228e18ca13c7b8d0f44ab8fb6","after":"7463f4bfbe20c0e618e45ae0cc43268da9ed4cff","ref":"refs/heads/main","pushedAt":"2024-01-22T16:03:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Foxboron","name":"Morten Linderud","path":"/Foxboron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1042946?s=80&v=4"},"commit":{"message":"Fix pacman cache removal in Arch image\n\nSigned-off-by: Robin Candau <robincandau@protonmail.com>","shortMessageHtmlLink":"Fix pacman cache removal in Arch image"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUOCAkwA","startCursor":null,"endCursor":null}},"title":"Activity · containers/toolbox"}