DeleteImage(): always delete mapped top layers #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your desciption is a little contradictory? |
|
The main distinction is mapped vs unmapped? |
When deleting an image, always delete an image's mapped top layers, even when the unmapped top layer is shared with other images and must therefore not be deleted. Mapped top layers aren't shared with other images, so we never need to preserve them. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
always-delete-mapped-layers
branch
from
39e9a25
to
ff62c5b
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an image, always delete an image's mapped top layers, even
ifwhen the unmapped top layer is shared with other images and must therefore not be deleted.