pkg/archive/overlayWhiteoutConverter.ConvertWrite(): force mode to 0 #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force the mode for whiteouts that have been converted from overlay format (produced by overlay native diff) to aufs format to 0x0, to match the permissions we assign to whiteouts we create when using naive diff. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
LGTM, I take it this will still work fine in rootless mode. |
|
It's not a difference between rootful and rootless so much as a difference between native vs naive diff (on my system, root uses naive diff because CONFIG_OVERLAY_FS_REDIRECT_DIR is detected, while that isn't detected for me, so I get to use native diff), so yes. |
|
|
|
Please ignore my above comment, discussed it with @nalind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the mode for whiteouts that have been converted from overlay format (produced by overlay native diff) to aufs format to 0x0, to match the permissions we assign to whiteouts we create when using naive diff.
Fixes #1195.