Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix storage-chown-by-maps doesnt handle -EOVERFLOW on lgetxattr [Closes #1183] #1190

Merged
merged 1 commit into from Apr 7, 2022

Conversation

robertzaage
Copy link
Contributor

@robertzaage robertzaage commented Apr 6, 2022

Signed-off-by: Robert Zaage robert@zaage.it

@rhatdan
Copy link
Member

rhatdan commented Apr 6, 2022

Can you merge your PRs together and rebase and repush.

@rhatdan
Copy link
Member

rhatdan commented Apr 6, 2022

LGTM Once you fix your PR.

@rhatdan
Copy link
Member

rhatdan commented Apr 6, 2022

Now you need to sign your commit.
git commit -a --amend -s
git push --force

@rhatdan
Copy link
Member

rhatdan commented Apr 6, 2022

@giuseppe PTAL

@robertzaage
Copy link
Contributor Author

Hmm looks like i swapped the github relay email with my personal email in my latest commit... fixed and signed 👍🏻

@giuseppe
Copy link
Member

giuseppe commented Apr 6, 2022

Patch LGTM. Could you please use your full name in the Signed-off-by line?

@TomSweeneyRedHat
Copy link
Member

Patch LGTM, but it looks like you need to rebase.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 5d55c44 into containers:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants