Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idtools: don't say ToHost() makes exceptions in its godoc when it doesn't #1185

Merged
merged 1 commit into from Mar 31, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Mar 30, 2022

The godoc for pkg/idtools.ToHost() mentions that it makes an exception when either of the IDs to be mapped is 0, but that special case was removed in #1057.

…sn't

The godoc for pkg/idtools.ToHost() mentions that it makes an exception
when either of the IDs to be mapped is 0, but that special case was
removed in containers#1057.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit bb2843d into containers:main Mar 31, 2022
@nalind nalind deleted the lies-in-comments branch March 31, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants