Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman + latest c-storage: thinpool throws a warning #22473

Closed
edsantiago opened this issue Apr 23, 2024 · 5 comments · Fixed by containers/storage#1908
Closed

podman + latest c-storage: thinpool throws a warning #22473

edsantiago opened this issue Apr 23, 2024 · 5 comments · Fixed by containers/storage#1908

Comments

@edsantiago
Copy link
Collaborator

With latest c-storage:

$ bin/podman pull -q quay.io/libpod/testimage:20240123
WARN[0000] Failed to decode the keys ["storage.options.thinpool"] from "/usr/share/containers/storage.conf" 
1f6acd4c4a1d4d39395870e1c12dbb68da27dd432afecf86e7cb6e23cf4b75d0
@edsantiago edsantiago changed the title podman + latest c-storage: thinpool is now an error podman + latest c-storage: thinpool throws a warning Apr 23, 2024
@Luap99
Copy link
Member

Luap99 commented Apr 23, 2024

see containers/storage@137ba2c

I guess the default storage.conf in the containers-common rpm has to get updated to remove the section.

@edsantiago
Copy link
Collaborator Author

I would humbly suggest that a better solution would be to fix storage.conf first, then wait for it to distribute everywhere that podman can possibly run, and then settle, and then remove thinpool from podman.

@Luap99
Copy link
Member

Luap99 commented Apr 23, 2024

FYI: thinpool was never part of podman (well not for years)

@edsantiago
Copy link
Collaborator Author

Sorry, I misspoke due to haste.

As a podman user, I am not likely to know or care what thinpool is. If I upgrade podman, maybe on some distro that is not 100% careful about bumping c-common, I will see the above warning and I will waste time worrying about it. Multiply by hundreds or thousands of users.

I would like to encourage our team to take steps such that no user ever sees this warning. (Possible exception for someone with a custom /etc file, but even then it should say "that block of settings has not worked for a long time, please remove everything from [storage.options.thinpool] to the next bracketed section".)

@rhatdan
Copy link
Member

rhatdan commented Apr 23, 2024

Rawhide should have it removed now. We could tone down containers/storage verifying its storage.conf file, but that could lead to people adding bad settings and not knowing they have typos in storage.conf files.

rhatdan added a commit to rhatdan/storage that referenced this issue Apr 24, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 24, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 24, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 24, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 24, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 25, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue Apr 26, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/storage that referenced this issue May 13, 2024
Fixes: containers/podman#22473

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants