Unreachable code in storage/drivers/overlay/overlay.go

[eriksjolund]

Could this if statement be removed?

storage/drivers/overlay/overlay.go

Lines 1503 to 1506 in 2431799

	if err == nil && !permsKnown {
	perms = os.FileMode(st.Mode())
	permsKnown = true
	}

It seems that permsKnown already needs to be true, because otherwise the for loop would have been skipped.

Here is the relevant code:

storage/drivers/overlay/overlay.go

Lines 1495 to 1507 in 2431799

	if err == nil {
	perms = os.FileMode(st.Mode())
	permsKnown = true
	}
	for err == nil {
	absLowers = append(absLowers, filepath.Join(dir, nameWithSuffix("diff", diffN)))
	diffN++
	st, err = os.Stat(filepath.Join(dir, nameWithSuffix("diff", diffN)))
	if err == nil && !permsKnown {
	perms = os.FileMode(st.Mode())
	permsKnown = true
	}
	}

The code originates from the PR

• overlay: set permissions on "diff" correctly #772

[rhatdan]

@giuseppe @mtrmac PTAL