Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAIL: TestSetRemapUserGroupOpts #1715

Open
siretart opened this issue Sep 14, 2023 · 4 comments
Open

FAIL: TestSetRemapUserGroupOpts #1715

siretart opened this issue Sep 14, 2023 · 4 comments

Comments

@siretart
Copy link
Contributor

The test added in #1620 fails while building the debian package:

=== RUN   TestSetRemapUserGroupOpts
    options_test.go:194: 
        	Error Trace:	/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/github.com/containers/storage/types/options_test.go:194
        	Error:      	Received unexpected error:
        	            	no subuid ranges found for user "siretart" in /etc/subuid
        	Test:       	TestSetRemapUserGroupOpts
--- FAIL: TestSetRemapUserGroupOpts (0.00s)

cc: @sstosh

@siretart
Copy link
Contributor Author

I believe the test makes assumptions that hold in CI but not on the build machines in Debian (and probably other distributions). Any chance to make the test skip automatically if /etc/subuild is not setup appropriately? -- I'd prefer to not distro patch this issue if possible

@rhatdan
Copy link
Member

rhatdan commented Sep 14, 2023

I am fine with that, but what is the test? If root or entry in /etc/subuid?

@rhatdan rhatdan closed this as completed Sep 14, 2023
@rhatdan rhatdan reopened this Sep 14, 2023
@siretart
Copy link
Contributor Author

Debian builds often run in https://manpages.debian.org/testing/pseudo/fakeroot.1.en.html -- so just testing for UID==0 might not be the best choice. Checking for entry in /etc/subuid seems more reliable to me

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2023

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants