overlay: use xattrs perms with network FSs #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
from
30bb91b
to
93e5c31
Compare
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
from
93e5c31
to
8928e95
Compare
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
from
8928e95
to
d134dc1
Compare
flouthoc
reviewed
Sep 29, 2021
rhatdan
reviewed
Sep 29, 2021
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
from
d134dc1
to
f7f2785
Compare
|
We can see if the Warnf is too agravating, or is easy enough to fix. |
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
2 times, most recently
from
8fb0a8e
to
0651ee6
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
when running on NFS, a RemoveAll could cause EBUSY because of some unlinked files that are still kept open and "silly renamed" to .nfs$ID. These files could be kept open by conmon and the issue is addressed by: containers/conmon#300 Before failing, attempt a few more times. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
when running in a user namespace on a network file system, automatically switch on the permission xattrs feature so that users won't have to tweak their storage.conf file with difficult to guess options. The list of remote file systems was taken from coreutils stat: https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/stat.c;h=0c34501e34410b9096edf377654b9ff27fe9fa24;hb=HEAD#l260 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
nfs-auto-xattrs
branch
from
0651ee6
to
175c8db
Compare
flouthoc
approved these changes
Sep 30, 2021
|
LGTM, Restarted failing test but not sure if it was a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running in a user namespace on a network file system, automatically switch on the permission xattrs feature so that users
won't have to tweak their storage.conf file with difficult to guess options.
The list of remote file systems was taken from coreutils stat:
https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/stat.c;h=0c34501e34410b9096edf377654b9ff27fe9fa24;hb=HEAD#l260
Also fix an issue with "silly renames" on NFS, more details in the commit log.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com