chunked: implement OSTree deduplication #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Sep 22, 2021
| @@ -1024,6 +1074,21 @@ func (c *chunkedDiffer) ApplyDiff(dest string, options *archive.TarOptions) (gra | |||
| continue | |||
| } | |||
|
|
|||
| found, dstFile, _, err = findFileInOSTreeRepos(&r, ostreeRepos, dirfd, useHardLinks) | |||
There was a problem hiding this comment.
Can found be false and dstFIle != nil? Or found be true and dstFile be nil?
If not then the function should only return dstFile.
There was a problem hiding this comment.
yes, it can return found == true, and dstNil == nil when doing hard links deduplication so the destination file is not overwritten.
There was a problem hiding this comment.
How about found ==false dstNil != nil?
There was a problem hiding this comment.
no that is not possible. If the file is not found then the destination is not opened
There was a problem hiding this comment.
It would make this clearer if it said
if found {
if dstFile != nil {
if err := setFileAttrs(dstFile, mode, &r, options); err != nil {
dstFile.Close()
return output, err
}
dstFile.Close()
}
continue
}
There was a problem hiding this comment.
I've simplified it further and pushed a new version
giuseppe
force-pushed
the
chunked-ostree-dedup
branch
2 times, most recently
from
54fdfe2
to
1aee04b
Compare
if the option ostree_repos is set:
[storage.options]
pull_options = {enable_partial_images = "true", ostree_repos = "/foo:/bar"}
then attempt to deduplicate from the specified list of OSTree repositories.
In order to be usable, an OSTree repository must be configured to track
the checksum for its files payload (payload link), that is disabled by
default:
ostree config --repo=/path/to/repo set core.payload-link-threshold N
Where N is the minimum size for files to be tracked by their payload
and must be a nonzero value.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
chunked-ostree-dedup
branch
from
1aee04b
to
a5a3c60
Compare
flouthoc
reviewed
Sep 24, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the option ostree_repos is set:
then attempt to deduplicate from the specified list of OSTree repositories.
In order to be usable, an OSTree repository must be configured to track
the checksum for its files payload (payload link), that is disabled by
default:
ostree config --repo=/path/to/repo set core.payload-link-threshold N
Where N is the minimum size for files to be tracked by their payload
and must be a nonzero value.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com