Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests leak buildah tmp direcories #22642

Open
Luap99 opened this issue May 8, 2024 · 3 comments · Fixed by containers/buildah#5527
Open

system tests leak buildah tmp direcories #22642

Luap99 opened this issue May 8, 2024 · 3 comments · Fixed by containers/buildah#5527

Comments

@Luap99
Copy link
Member

Luap99 commented May 8, 2024

Working on my tmpfs PR I defined a new TMPDIR and after the test I try to remove the tmpdir but this failed rootless with missing permissions, it seems that we have leaked buildah tmp dirs after running the systems test, need to debug further to know which test leaks them

rm: cannot remove '/tmp/CI_19FE/buildah476548106/mnt': Permission denied
@edsantiago
Copy link
Collaborator

Directories of the form tmpdir/buildahNNN are (I'm 99% sure) droppings from buildah, not system tests. Perhaps from here https://github.com/containers/buildah/blob/983fa426d03b4348f2d2bd02ad277cd3a5c95595/run_common.go#L1738

@Luap99
Copy link
Member Author

Luap99 commented May 8, 2024

Directories of the form tmpdir/buildahNNN are (I'm 99% sure) droppings from buildah, not system tests. Perhaps from here https://github.com/containers/buildah/blob/983fa426d03b4348f2d2bd02ad277cd3a5c95595/run_common.go#L1738

yes correct, I was not implying that this is a bug in our test code just that executing the tests leaks the files/dirs.

@edsantiago
Copy link
Collaborator

One reproducer (there may be more):

$ bin/podman build --authfile=/tmp/bogus - <<<"from scratch" 
Error: credential file is not accessible: faccessat /tmp/bogus: no such file or directory
$ ls -la $TMPDIR/buildah*
total 4
drwx------.  2 esm  esm   60 May  8 10:18 ./
drwxrwxrwt. 38 root root 900 May  8 10:18 ../
-rw-------.  1 esm  esm   13 May  8 10:18 Dockerfile

Curiously, does not reproduce with s/podman/buildah/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants