Maybe return statements are missing in podman/pkg/domain/infra/abi/containers.go ?

[eriksjolund]

In this for loop

podman/pkg/domain/infra/abi/containers.go

Lines 1113 to 1125 in b8a684b

	for _, r := range responses {
	report.Id = r.Id
	report.ExitCode = 0
	if r.Err != nil {
	logrus.Errorf("Failed to restore checkpoint image %s: %v", resolvedImageName, r.Err)
	report.ExitCode = 126
	}
	if r.RawInput != "" {
	logrus.Errorf("Failed to restore checkpoint image %s: %v", resolvedImageName, r.RawInput)
	report.ExitCode = 126
	}
	}
	return &report, nil

It looks like one iteration could set report.ExitCode like this

report.ExitCode = 126

and possibly the next iteration could set report.ExitCode like this

report.ExitCode = 0

At first sight it looks like that there are return statements missing inside the loop.

I don't know this code so I might be wrong.
What do you think?

[Luap99]

responses should only ever be length 1 here as we only pass one name to ic.ContainerRestore() so it should not be problem, although yeah the code never enforces that assumption.

[eriksjolund]

Thanks for clarifying!