Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions README does not show HTML #7033

Open
cdrage opened this issue Apr 30, 2024 · 3 comments
Open

Extensions README does not show HTML #7033

cdrage opened this issue Apr 30, 2024 · 3 comments
Labels
area/ui-components kind/enhancement ✨ Issue for requesting an improvement

Comments

@cdrage
Copy link
Contributor

cdrage commented Apr 30, 2024

Bug description

Unsure if this is intentional or not, but you cannot show HTML in the extensions readme:

Screenshot 2024-04-30 at 10 40 43 AM

Operating system

mac m1

Installation Method

None

Version

1.10.0

Steps to reproduce

Put HTML in an extensions README.

It's not rendered correctly.

Relevant log output

No response

Additional context

No response

@cdrage cdrage added the kind/bug 🐞 Something isn't working label Apr 30, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 30, 2024
### What does this PR do?

* PD does not support HTML in extension README's (yet)
* Reduces size of logo to 200px x 200px
* Moves the logo down below the title as well as makes it markdown only.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

See markdown

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Related to containers/podman-desktop#7033

### How to test this PR?

<!-- Please explain steps to reproduce -->

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
deboer-tim pushed a commit to containers/podman-desktop-extension-bootc that referenced this issue Apr 30, 2024
### What does this PR do?

* PD does not support HTML in extension README's (yet)
* Reduces size of logo to 200px x 200px
* Moves the logo down below the title as well as makes it markdown only.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

See markdown

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Related to containers/podman-desktop#7033

### How to test this PR?

<!-- Please explain steps to reproduce -->

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@deboer-tim
Copy link
Collaborator

It would be nice to have this, but just confirming that we've changed the readme for now so this is not blocking.

@odockal
Copy link
Contributor

odockal commented Apr 30, 2024

Isn't it supposed to be markdown format instead of html?

@deboer-tim
Copy link
Collaborator

Yes, but Github allows you to embed simple html for some things that are difficult in markdown (e.g. in this case including a scaled and centred image), so it's not uncommon for little bits to slip into a readme.

@benoitf benoitf added area/ui-components kind/enhancement ✨ Issue for requesting an improvement and removed status/need-triage kind/bug 🐞 Something isn't working labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-components kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants