Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strings.NewReader instead of bytes.NewBufferString #1517

Merged
merged 1 commit into from Apr 25, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Apr 5, 2022

Just a micro-optimization: avoid maintaining state for a read/write buffer, and the allocation inherent in a string[]byte conversion.

@rhatdan
Copy link
Member

rhatdan commented Apr 5, 2022

LGTM

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
I've restarted the tests, it looked like a flakey network error talking to a registry.

Just a micro-optimization: avoid maintaining state for
a read/write buffer, and the allocation inherent in a
string -> []byte conversion.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@TomSweeneyRedHat
Copy link
Member

Happy green test buttons
LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 9fe075b into containers:main Apr 25, 2022
@mtrmac mtrmac deleted the strings.NewReader branch April 25, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants