Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting a SIF image should not require fakeroot #2184

Open
kincl opened this issue Nov 11, 2023 · 4 comments
Open

Converting a SIF image should not require fakeroot #2184

kincl opened this issue Nov 11, 2023 · 4 comments
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@kincl
Copy link

kincl commented Nov 11, 2023

When converting a SIF image to run with podman it requires fakeroot but shouldn't we be able to use userns instead?

$ podman run sif:lolcow_1.0.sif
Error: converting rootfs from SquashFS to Tarball: converting image: exec: "fakeroot": executable file not found in $PATH, output:
@rhatdan
Copy link
Member

rhatdan commented Nov 12, 2023

The Linux kernel will not allow mounting of squashfs directly so we need a fuse file system to mount it.

@kincl
Copy link
Author

kincl commented Nov 12, 2023

The Linux kernel will not allow mounting of squashfs directly so we need a fuse file system to mount it.

@rhatdan it looks like the first pass at supporting this was to use fakeroot with unsquashfs to avoid the issue of mounting squashfs entirely so I was just thinking of fixing that part of it but I agree that using something like squashfuse is probably the best solution here.

@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2023

SGTM.

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 13, 2023

In principle, this could be an entirely in-userspace in-memory conversion which does not require any creation of files with different UIDs, nor any mounting.

But that code just doesn’t exist right now, and for a one-time migration aid like this, which shouldn’t be a permanent part of any workflows, it seems to me that it is not worth very much unique investment of this kind.

@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

No branches or pull requests

3 participants