Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clarification] copy.CopySpecifcImages and Instances list #1661

Open
tumberino opened this issue Sep 22, 2022 · 2 comments · May be fixed by #1707
Open

[Clarification] copy.CopySpecifcImages and Instances list #1661

tumberino opened this issue Sep 22, 2022 · 2 comments · May be fixed by #1707
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@tumberino
Copy link

Hi,

Not sure if this is a bug or the intended behaviour so asking for clarification. When using the CopySpecifcImages it will copy the images listed in the Instances field but then try to put the entire manifest list into the destination which will only have the updated details for those copied as part of the Instances.

This will result in seeing manifest blob unknown: blob unknown to registry error, because there will be blobs referenced in the manifest that have not been included in the copy because they are not in the Instances list.

The language in the documentation for CopySpecifcImages does have the line "along with the list itself". Is this useful behaviour?

The usecase for this is to be able to copy only specific architectures from a multi-arch manifest rather than copying across all which can be costly storage. 1-2 GB wasted from unrequired archs.
@mtrmac
Copy link
Collaborator

mtrmac commented Sep 22, 2022

Thanks for reaching out.

This is the intended, or at least as-of-this-point-frozen, behavior; e.g. #1483 (review) points at a specific constraint.

The alternate, of copying only a subset, and modifying the manifest list (at the price of breaking digest references to the manifest list), is a reasonable feature to perhaps add in the future. (And nowadays we have some ways to make the compatibility constraints mentioned in #1483 less constraining, e.g. c/image/internal/private.)

@mtrmac
Copy link
Collaborator

mtrmac commented Dec 9, 2022

#1707 will allow modifying the manifest list.

@mtrmac mtrmac linked a pull request Dec 9, 2022 that will close this issue
Add copy option to strip sparse manifests #1707
Open
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add copy option to strip sparse manifests bertbaron/image
2 participants
@mtrmac @tumberino