Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a direct dependency on golang.org/x/sys #1479

Merged
merged 1 commit into from Feb 25, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Feb 24, 2022

After #1477 has removed the last direct user of the package, update also the dependency.

Don't completely remove it so that updating c/image can't cause a downgrade of golang.org/x/sys in consumers;
eventually some dependency will start requiring a newer version of golang.org/x/sys and the entry will completely
drop out (or we eventually update to the newer go.mod format that lists indirect dependencies as well).

After containers#1477
has removed the last direct user of the package, update
also the dependency.

Don't completely remove it so that updating c/image can't
cause a downgrade of golang.org/x/sys in consumers;
eventually some dependency will start requiring a newer
version of golang.org/x/sys and the entry will completely
drop out (or we eventually update to the newer go.mod format
that lists indirect dependencies as well)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@vrothberg vrothberg merged commit 34a3bc2 into containers:main Feb 25, 2022
@mtrmac mtrmac deleted the drop-dependency branch February 25, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants