Remove keyring support #1477
Merged
Remove keyring support #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package is not used, noone is currently working on wiring it up, and it started failing in CI (apparently because it assumes the user's keyring is empty when tests start, which is now not reliably the case). Instead of fixing the tests, just remove it; we can always restore the code from Git history. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
vrothberg
reviewed
Feb 23, 2022
|
LGTM |
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Feb 24, 2022
After containers#1477 has removed the last direct user of the package, update also the dependency. Don't completely remove it so that updating c/image can't cause a downgrade of golang.org/x/sys in consumers; eventually some dependency will start requiring a newer version of golang.org/x/sys and the entry will completely drop out (or we eventually update to the newer go.mod format that lists indirect dependencies as well) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/image
that referenced
this pull request
Feb 24, 2022
After containers#1477 has removed the last direct user of the package, update also the dependency. Don't completely remove it so that updating c/image can't cause a downgrade of golang.org/x/sys in consumers; eventually some dependency will start requiring a newer version of golang.org/x/sys and the entry will completely drop out (or we eventually update to the newer go.mod format that lists indirect dependencies as well) Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is not used, no-one is currently working on wiring it up, and it started failing in CI (apparently because it assumes the user's keyring is empty when tests start, which is now not reliably the case).
Instead of fixing the tests, just remove it; we can always restore the code from Git history.