Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/manifoldco/promptui from 0.8.0 to 0.9.0 #1399

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 2, 2021

Bumps github.com/manifoldco/promptui from 0.8.0 to 0.9.0.

Release notes

Sourced from github.com/manifoldco/promptui's releases.

v0.9.0

What's Changed

New Contributors

Full Changelog: manifoldco/promptui@v0.8.0...v0.9.0

Changelog

Sourced from github.com/manifoldco/promptui's changelog.

[0.9.0] - 2021-10-30

Fixed

  • Resolve license incompatibility in tabwriter
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/manifoldco/promptui](https://github.com/manifoldco/promptui) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/manifoldco/promptui/releases)
- [Changelog](https://github.com/manifoldco/promptui/blob/master/CHANGELOG.md)
- [Commits](manifoldco/promptui@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: github.com/manifoldco/promptui
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 2, 2021
@mtrmac
Copy link
Collaborator

mtrmac commented Nov 4, 2021

@cevich Per https://cirrus-ci.com/build/6334235716878336 the tests have (after re-running one) all succeeded, but this is not visible in the GitHub UI. Is there a way to re-sync the two?

@cevich
Copy link
Member

cevich commented Nov 5, 2021

but this is not visible in the GitHub UI. Is there a way to re-sync the two?

Oof, I believe this is a known (and very annoying) github bug. No, I don't believe there is a way other than re-running all the tests with a new push 😖 Investigating further...

@cevich
Copy link
Member

cevich commented Nov 5, 2021

...yeah, spent some time poking around with google. There is a long and sorted history with these status "badges" (as they're called) being out-of-sync or simply wrong. It's not specific to Cirrus-CI, I've seen this problem in github-actions as well. I'm thinking maybe if I re-run just the 'success' job, that might help. If not, I'd just use the admin-privs and merge (assuming that's the intent). Unless you want to re-push and wait 😁

@cevich
Copy link
Member

cevich commented Nov 5, 2021

Nope, no change after re-running Total Success ☹️

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 5, 2021

@dependabot recreate

Thanks. Let’s see if we can get the tooling to retry, and avoid manual steps. If that fails, we can merge manually.

@cevich
Copy link
Member

cevich commented Nov 5, 2021

Oof, it looks like it did the same thing again 😕 What a strange issue, and even more odd that we don't (AFAIK) see this elsewhere. I'd put my money on it being a github problem, but it's possible something else is broken. I wrote to Cirrus support about this (cc'd you). Let's see what they have to say.

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 5, 2021

The bot is done with the “recreate” command, but I don’t see a new commit, so it presumably detected that it doesn’t need one — and I don’t see new Cirrus runs.

We can leave this PR around for a while as an experiment, and after merging a c/image commit for other reasons, let the bot rebase again.

Or would it be better not to touch it at all now, so that Cirrus support can take a look?

(Per release notes, it’s fixing a license incompatibility , so I’d prefer to merge it soonish.)

@cevich
Copy link
Member

cevich commented Nov 8, 2021

Or would it be better not to touch it at all now, so that Cirrus support can take a look?

Yes, so long as it's not super-critical to get merged in, let's leave it alone for Cirrus-support to have a chance to look. I'm still betting on it being a github issue, given the huge number of similar/related issues google turns up. But since it's happening repeatedly now, and only on this repo. (so far) it would be good to get to the bottom of it. It's possible something in our setup is broken and that's causing it.

@cevich
Copy link
Member

cevich commented Nov 9, 2021

Shortly we will be needing to update the VM images in this repo, so I opened a draft PR 1404. This is also to test a hunch: If this problem is present for (new) human-generated PRs or only (this) dependabot PR. Accounts/permissions in github are a duct-tape and bubblegum salad IMHO. It wouldn't surprise me if this is what's behind the status weirdness.

@cevich
Copy link
Member

cevich commented Nov 9, 2021

So PR 1404 is definitely reporting/updating the status badges properly. I'm thinking the problems here must be some weirdness relating to the PR being owned/triggered by the dependabot "user". We'll definitely need Cirrus-support to take a look.

@cevich
Copy link
Member

cevich commented Nov 9, 2021

@mtrmac you can go ahead and merge this manually if you like. Cirrus-CI has a patch going in on the 10th that should fix the problem for future PRs.

@mtrmac
Copy link
Collaborator

mtrmac commented Nov 10, 2021

@cevich Thanks for tracking this and having Cirrus fix it.

@mtrmac mtrmac merged commit 931b399 into main Nov 10, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/manifoldco/promptui-0.9.0 branch November 10, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants