From 72d094c04d87b522f282075da7b7651fca8d14a3 Mon Sep 17 00:00:00 2001 From: Aditya R Date: Thu, 24 Feb 2022 16:30:25 +0530 Subject: [PATCH] storage: use race-free AddNames instead of SetNames Commits from parallel builds using `SetNames` removes `names` from storage for other builds. Use race-free atomic `AddNames` to prevent breaking of parallel builds. Signed-off-by: Aditya R --- storage/storage_image.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/storage_image.go b/storage/storage_image.go index bcb09c83ce..62ef566f6b 100644 --- a/storage/storage_image.go +++ b/storage/storage_image.go @@ -1207,7 +1207,7 @@ func (s *storageImageDestination) Commit(ctx context.Context, unparsedToplevel t if len(oldNames) > 0 { names = append(names, oldNames...) } - if err := s.imageRef.transport.store.SetNames(img.ID, names); err != nil { + if err := s.imageRef.transport.store.AddNames(img.ID, names); err != nil { logrus.Debugf("error setting names %v on image %q: %v", names, img.ID, err) return errors.Wrapf(err, "setting names %v on image %q", names, img.ID) }