From 65ae448bac0436fdf1b007a251b9f2f1f2622824 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Sat, 11 Jun 2022 02:50:57 +0200 Subject: [PATCH] FIXME FIXME: Add FIXMEs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miloslav Trmač --- copy/copy.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/copy/copy.go b/copy/copy.go index 57a8d5f1e4..01b5dc4694 100644 --- a/copy/copy.go +++ b/copy/copy.go @@ -690,6 +690,7 @@ func (c *copier) copyOneImage(ctx context.Context, policyContext *signature.Poli // that the compressed version coming from a third party may be designed to attack some other decompressor implementation, // and we would reuse and sign it. // - Finally, let the image format handler influence this (in particular to disable substitution for OCI artifacts). + // FIXME: More debug logs about this decision? ic.canSubstituteBlobs = ic.cannotModifyManifestReason == "" && options.SignBy == "" && ic.src.CanSubstituteLayers() if err := ic.updateEmbeddedDockerReference(); err != nil { @@ -1413,6 +1414,7 @@ func (ic *imageCopier) copyBlobFromStream(ctx context.Context, srcStream io.Read canModifyBlob := !isConfig && ic.cannotModifyManifestReason == "" // === Deal with layer compression/decompression if necessary layerCompressionChangeSupported := ic.src.CanChangeLayerCompression(srcInfo.MediaType) + // FIXME: More debug logs about this decision? canChangeCompression := canModifyBlob && layerCompressionChangeSupported compressionMetadata := map[string]string{} var inputInfo types.BlobInfo