libimage: load: improve error messages #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
force-pushed
the
load-error
branch
from
f01bc8a
to
bcb554d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Sep 24, 2021
When loading a path we have to "guess" the underlying format and hence attempt loading supported formats in a specific order. When all attempts have failed make sure that all loading errors are reported up, in addition to debug logs, such that users can parse them for useful information. Fixes: github.com/containers/podman/issues/11730 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg
force-pushed
the
load-error
branch
from
bcb554d
to
b39f9e8
Compare
|
@Luap99 PTanotherL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a path we have to "guess" the underlying format and hence
attempt loading supported formats in a specific order. When all
attempts have failed make sure that all loading errors are reported up,
in addition to debug logs, such that users can parse them for useful
information.
Fixes: github.com/containers/podman/issues/11730
Signed-off-by: Valentin Rothberg rothberg@redhat.com
@containers/podman-maintainers PTAL