Add machine table to containers.conf #782
Conversation
ashley-cui
force-pushed
the
machine
branch
2 times, most recently
from
43a2fbe
to
0ee6047
Compare
| **disk_size**=10 | ||
|
|
||
| The size of the disk in GB created when init-ing a podman-machine VM | ||
|
|
There was a problem hiding this comment.
Sure, I can wire that in now
There was a problem hiding this comment.
And I guess memory as well?
|
@rhatdan ptal |
Add machine teable to configure podman machine options. Move machine_image to the machine table, and add cups, disk size, and memory to the machine table. Signed-off-by: Ashley Cui <acui@redhat.com>
|
LGTM |
| // MachineImage is the image used when creating a podman-machine VM | ||
| MachineImage string `toml:"machine_image,omitempty"` |
There was a problem hiding this comment.
This field is not in podman 3.3, right? In this case I would want this PR and the podman wiring to get into podman 3.4 so that we do not have to worry about backwards compat for this field.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
This broke vendoring c/common in Podman. Please always make sure to open a PR against Podman and vendor in the commit once it has merged (e.g., Waiting for a release of c/common is a too big time window as it blocks others (in this case me) from working on c/common and Podman. |
|
@vrothberg There is containers/podman#11741? |
|
I took over Dan's PR to push things forward -> containers/podman#11753
CI is red. For breaking changes, c/common PRs should only get merged once the Podman PR is green. Then we can do the vendor dance and vendor main (e.g., containers/podman#11737). |
|
Ahh okay my bad, will open the podman PR first next time |
Add machine teable to configure podman machine options. Move
machine_image to the machine table, and add disk size to the machine
table.
Signed-off-by: Ashley Cui acui@redhat.com