Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the fallback runtime path #759

Merged
merged 1 commit into from Sep 8, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 8, 2021

Podman should not use /tmp/run-.... The Podman PR#8241 changed the
path to /tmp/podman-run-... and added systemd tmpfile config to make
sure the path is not removed. However the tmpDir is set in c/common and
was never changed.

Fixes containers/podman#11478

Signed-off-by: Paul Holzinger pholzing@redhat.com

Podman should not use `/tmp/run-...`. The Podman PR#8241 changed the
path to `/tmp/podman-run-...` and added systemd tmpfile config to make
sure the path is not removed. However the tmpDir is set in c/common and
was never changed.

Fixes containers/podman#11478

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 8, 2021

LGTM
@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Sep 8, 2021

Ouch. LGTM

@mheon
Copy link
Member

mheon commented Sep 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit f907b47 into containers:main Sep 8, 2021
@Luap99 Luap99 deleted the runtimePath branch September 8, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman containers running in "Created" status
4 participants