Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for --pull in buildah build --help is incorrect #5406

Open
brickmonster opened this issue Mar 16, 2024 · 1 comment · May be fixed by #5407
Open

Documentation for --pull in buildah build --help is incorrect #5406

brickmonster opened this issue Mar 16, 2024 · 1 comment · May be fixed by #5407

Comments

@brickmonster
Copy link

Description

Documentation for the --pull flag is incorrect/missing.

  1. --pull=false in the help menu states that it only pulls if not present, but the man page states (correctly) that it never pulls.
  2. --pull=missing is missing from the help menu.

Emphasis mine.

buildah build --help states:

pull base and SBOM scanner images from the registry if newer or not present in store, if false, only pull base and SBOM scanner images IF NOT PRESENT, if always, pull base and SBOM scanner images even if the named images are present in store, if never, only use images present in store if available (default "true")

man buildah-build states:

When the --pull flag is enabled or set explicitly to true (with --pull=true), attempt to pull the latest versions of base and SBOM scanner images from the registries listed in registries.conf if a local base or SBOM scanner image does
not exist or the image in the registry is newer than the one in local storage. Raise an error if the base or SBOM scanner image is not in any listed registry and is not present locally.

If the flag is disabled (with --pull=false), DO NOT PULL base and SBOM scanner images from registries, use only local versions. Raise an error if a base or SBOM scanner image is not present locally.

If the pull flag is set to always (with --pull=always), pull base and SBOM scanner images from the registries listed in registries.conf. Raise an error if a base or SBOM scanner image is not found in the registries, even if an image
with the same name is present locally.

If the pull flag is set to missing (with --pull=missing), pull base and SBOM scanner images only if they could not be found in the local containers storage. Raise an error if no image could be found and the pull fails.

If the pull flag is set to never (with --pull=never), do not pull base and SBOM scanner images from registries, use only the local versions. Raise an error if the image is not present locally.

Output of buildah version:

Version:         1.35.0
Go Version:      go1.22.1
Image Spec:      1.1.0
Runtime Spec:    1.1.0
CNI Spec:        1.0.0
libcni Version:  v1.1.2
image Version:   5.30.0
Git Commit:      fedbd79676e8aa5dc49d9434f6d9361b5e00ba62
Built:           Wed Mar 13 15:50:38 2024
OS/Arch:         linux/amd64
BuildPlatform:   linux/amd64

Output of podman version if reporting a podman build issue:

Client:       Podman Engine
Version:      4.9.3
API Version:  4.9.3
Go Version:   go1.22.0
Git Commit:   8d2b55ddde1bc81f43d018dfc1ac027c06b26a7f-dirty
Built:        Fri Feb 16 16:18:03 2024
OS/Arch:      linux/amd64

Output of cat /etc/*release:

DISTRIB_ID="Arch"
DISTRIB_RELEASE="rolling"
DISTRIB_DESCRIPTION="Arch Linux"
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

Output of uname -a:

Linux desktop 6.6.21-1-lts #1 SMP PREEMPT_DYNAMIC Wed, 06 Mar 2024 16:59:55 +0000 x86_64 GNU/Linux
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 16, 2024
Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan linked a pull request Mar 16, 2024 that will close this issue
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 16, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 18, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 20, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 20, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 25, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Mar 31, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link

A friendly reminder that this issue had no activity for 30 days.

rhatdan added a commit to rhatdan/buildah that referenced this issue Apr 16, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Apr 20, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Apr 20, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/buildah that referenced this issue Apr 24, 2024
Use github.com/containers/common/pkg/config for handling pull policy.

No longer document --pull=true|false

Fixes: containers#5406

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant