Makefile: update cross targets #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the "cross" makefile target to just try building on every Linux, Darwin, or Windows architecture that the current version of Go supports. That way, the next time we upgrade Go to a version that supports more architectures, we won't have to remember to update the list of cross-compile targets that we try to build in CI to catch cross-compilation problems. Marking this as not needing new tests because it directly modifies one of our CI tests. [NO NEW TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
LGTM |
Update which version of Mac OS X we use for running the cross-compile check in CI from Catalina (10.15) to Big Sur (11). Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Update the "cross" makefile target to just try building on every Linux, Darwin, or Windows architecture that the current version of Go supports.
That way, the next time we upgrade Go to a version that supports more architectures, we won't have to remember to update the list of cross-compile targets that we try to build in CI to catch cross-compilation problems.
How to verify it
make cross, then look in ./binWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?