Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 05-openshift-rootless-build.md #3507

Merged
merged 2 commits into from Sep 10, 2021

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Sep 9, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:

When I tried to run "Buildah Tutorial 5" last step I got the following error:

$ buildah -v /home/build/output:/output:rw -v /home/build/test-script.sh:/test-script.sh:ro build -t myimage -f Containerfile.test
unknown command "build" for "buildah"

Did you mean this?
	build-using-dockerfile

To fix it I have replaced buildah "build" command with "build-using-dockerfile".

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 9, 2021
@flouthoc
Copy link
Collaborator

flouthoc commented Sep 9, 2021

@l0rd I think original documentation is correct following PR #3368 did a sed on /bud/build so on older version bud is applicable but on newer version build and bud both should work.

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2021

This LGTM, for now.

@l0rd you need to sign your commits.

git commit -a --amend -s
git push --force

Replace buildah "build" command with "build-using-dockerfile"

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@l0rd
Copy link
Contributor Author

l0rd commented Sep 10, 2021

@flouthoc from the doc "The instructions have been tested on OpenShift 4.3.28 with Buildah 1.14.8" and "FROM quay.io/buildah/stable:v1.14.8" make v1.14.8 the inevitable choice for those that are following the instructions step by step (as I did).

@rhatdan commit signed

Anyway I would be happy to update the doc to use the latest stable version of buildah (v1.22.3) and OpenShift (v4.8) if that's useful.

@rhatdan
Copy link
Member

rhatdan commented Sep 10, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l0rd, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0346b38 into containers:main Sep 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants