Remove references to io/ioutil package #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
mars1024
reviewed
Dec 6, 2022
| @@ -11,7 +10,7 @@ import ( | |||
|
|
|||
| var _ = Describe("IpforwardLinux", func() { | |||
| It("echo1 must not write the file if content is 1", func() { | |||
| file, err := ioutil.TempFile(os.TempDir(), "containernetworking") | |||
| file, err := os.CreateTemp("", "containernetworking") | |||
There was a problem hiding this comment.
the input dir here should not be changed to "" from os.TempDir()
There was a problem hiding this comment.
os.CreateTemp will call os.TempDir under the hood if dir is empty.
https://pkg.go.dev/os#CreateTemp
Would you still prefer the revert to the explicit call here?
|
seems fine, not sure why tests haven't run. hold please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io/ioutil package has been marked deprecated in Go 1.16.
https://go.dev/doc/go1.16#ioutil
Signed-off-by: Austin Vazquez macedonv@amazon.com