call ipam.ExecDel after clean up device in netns #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbw
reviewed
Feb 16, 2022
gojoy
changed the title
|
@gojoy could squash the new commit into the first one, so that the DCO is OK? |
|
@gojoy and can you |
fix containernetworking#666 Signed-off-by: gojoy <729324352@qq.com>
done |
done |
|
/lgtm |
|
lgtm, thanks |
EmilyShepherd
added a commit
to EmilyShepherd/kiOS
that referenced
this pull request
Dec 10, 2022
[This change][upstream] originally caused the bridge to clean up the interface before calling the DHCP plugin to clean up. Unfortuneately, this caused an error as DHCP requires the interface to still exist so it can release the IP address to the DHCP server. This patch reverts it as it is required in kios. Please see [the upstream issue][issue] for further discussion on this. [upstream]: containernetworking/plugins#702 [issue]: containernetworking/plugins#791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call ipam.ExecDel to release ip in ipam after clean up device in netns.,avoid ip conflict
fix #666
Signed-off-by: gojoy 729324352@qq.com