[main/vlan] Fix error handling for delegate IPAM plugin #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Skamruk <piotr.skamruk@gmail.com>
hudymi
reviewed
Jan 14, 2021
| @@ -152,7 +152,7 @@ func cmdAdd(args *skel.CmdArgs) error { | |||
| // run the IPAM plugin and get back the config to apply | |||
| r, err := ipam.ExecAdd(n.IPAM.Type, args.StdinData) | |||
| if err != nil { | |||
| return err | |||
| return fmt.Errorf("failed to execute IPAM delegate: %v", err) | |||
There was a problem hiding this comment.
NIT: It is a good practice to use %w instead of %v when adding additional context to errors to keep the original error type.
https://golang.org/pkg/fmt/#Errorf
There was a problem hiding this comment.
hint: check the convention used in the rest of the repo.
Fill welcomed to provide such change globally ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment error messages generated during execution of delegate IPAM plugin are indistinguishable from main
vlanmessages leading to cryptic messages likeno plugin name providedwhich IS hard to debug from a human operator level.This PR fixes that behavior.