Bump up github.com/ipld/go-codec-dagpb from v1.3.0 to v1.3.2 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Apr 13, 2022
cmd/go.mod
Outdated
|
|
||
| // Ensure v1.3.1+ is used to address https://github.com/advisories/GHSA-g3vv-g2j5-45f2 | ||
| // TODO: remove this replace dirctive once all dependencies are updated to point to v1.3.1+ | ||
| github.com/ipld/go-codec-dagpb => github.com/ipld/go-codec-dagpb v1.3.2 |
There was a problem hiding this comment.
Can't you just pin this version as an // indirect dependency in the require() section?
Maybe with go 1.17 format.
There was a problem hiding this comment.
github.com/ipld/go-codec-dagpb v1.3.2 is added to go.sum but it still contains github.com/ipld/go-codec-dagpb v1.3.0 entry (using go 1.17 didn't help).
I'm not sure this solves the dependabot alert.
Can we merge this and check if the dependabot alert is solved? If not solved, we'll need to use replace.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
force-pushed
the
bump-github.com/ipld/go-codec-dagpb
branch
from
0c4f05a
to
499bd67
Compare
AkihiroSuda
approved these changes
Apr 13, 2022
|
It seems that the dependabot alert has been solved. I'll prepare for release v0.11.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GHSA-g3vv-g2j5-45f2
This also solves recent dependabot error that fails to automatically upgread this package.
Similar patch will be needed for nerdctl as well.