Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage report for Pull Requests #509

Open
gtxu opened this issue Nov 2, 2021 · 2 comments
Open

Add test coverage report for Pull Requests #509

gtxu opened this issue Nov 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@gtxu
Copy link
Contributor

gtxu commented Nov 2, 2021

For now we have a unit test for all component before PR get merged, but we don't have unit test coverage report for a single PR. There are tools (such as Coveralls)that automatically post unit test coverage report for a PR in comment. This may be a considerable option for stargz-snapshotter.
@gtxu gtxu changed the title Add test coverage report for Pull Request Add test coverage report for Pull Requests Nov 2, 2021
@gtxu
Copy link
Contributor Author

gtxu commented Nov 2, 2021 •
edited

An example of coveralls:

Screen Shot 2021-11-02 at 3 12 43 PM

@ktock ktock added the enhancement New feature or request label Nov 3, 2021
@vkuzniet
Copy link
Contributor

vkuzniet commented Nov 5, 2021 •
edited

Hi @ktock, what do you think about adding this to the pipeline?

@gtxu gtxu mentioned this issue Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add unit test coverage in GitHub workflow
3 participants
@ktock @vkuzniet @gtxu