Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on adding coverprofile to make test action #460

Open
vkuzniet opened this issue Sep 15, 2021 · 2 comments
Open

Thoughts on adding coverprofile to make test action #460

vkuzniet opened this issue Sep 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vkuzniet
Copy link
Contributor

Hi All,
I noticed that make test action doesn't have -coverprofile enabled. I think it'll be beneficial for everyone to enable it, since it may help with showing the ratio of code covered by tests given that most likely people will run make test instead of running go test -race ./... -coverprofile ....
I would like to know what community thinks about that?
@ktock
Copy link
Member

ktock commented Sep 16, 2021

How about adding an environment variable for customizing go test options ? (like already done in some build targets)

stargz-snapshotter/Makefile

Line 39 in 25d16aa

GO111MODULE=$(GO111MODULE_VALUE) go build -o $(PREFIX)$@ $(GO_BUILD_FLAGS) $(GO_LD_FLAGS) -v ./cmd/containerd-stargz-grpc

@vkuzniet
Copy link
Contributor Author

That should work, thank you.
I will work on the PR.

@ktock ktock added the enhancement New feature or request label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktock @vkuzniet