store: Avoid access to Forgotten() before configured #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `Lookup()` implementation returns a newly created `*fusefs.Inode` to go-fuse. Then that `*fusefs.Inode` is configured and managed by go-fuse lib. Though [`*fusefs.Inode.Forgotten()`](https://github.com/hanwen/go-fuse/blob/e9e7c22af17af4611b5783a16458647088cc8dec/fs/inode.go#L258) allows status check of that object, it shouldn't be called until that `*fusefs.Inode` is [fully configured by go-fuse](https://github.com/hanwen/go-fuse/blob/e9e7c22af17af4611b5783a16458647088cc8dec/fs/bridge.go#L209-L210). To avoid this race, this commit adds a lock for avoiding calling Forgotten API during configuration on-going in go-fuse. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
changed the title
ktock
changed the title
This was referenced Mar 11, 2024
|
My understanding of the interactions between the go-fuse and stargz-snapshotter parts of the code may be off here, but won't the I think a simpler fix would be to used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594
Our
Lookup()implementation returns a newly created*fusefs.Inodeto go-fuse. Then that*fusefs.Inodeis configured and managed by go-fuse lib.Though
*fusefs.Inode.Forgotten()allows status check of that object, it shouldn't be called until that*fusefs.Inodeis fully configured by go-fuse. Otherwize we hit issue like #1594.To avoid this race, this commit adds a lock for avoiding calling
*fusefs.Inode.Forgotten()during configuration on-going in go-fuse.