Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshots: Fix error when switching different snapshotters #592

Closed
ChengyuZhu6 opened this issue Apr 28, 2024 · 1 comment · Fixed by #593
Closed

snapshots: Fix error when switching different snapshotters #592

ChengyuZhu6 opened this issue Apr 28, 2024 · 1 comment · Fixed by #593
Labels
bug Something isn't working

Comments

@ChengyuZhu6
Copy link
Contributor

On proxy driver, we found an issue that if we use other snapshotter (like overlayfs) to pull an image and then switching to nydus to pull the same image, we would get the error: "error unpacking image: failed to extract layer sha256:1021ef88c7974bfff89c5a0ec4fd3160daac6c48a075f74cff721f85dd104e68: failed to get reader from content store: content digest sha256:fbe1a72f5dcd08ba4ca3ce3468c742786c1f6578c1f6bb401be1c4620d6ff705: not found"
same issue: kata-containers/kata-containers#8407

This error occurs because the image puller has an optimization that skips downloading the layer related to the image, if it is already unpacked as a snapshot in the default snapshotter (overlayfs).

The error could be fixed on proxy driver. The logic behind proxy mode is simple: by inserting the label containerd.io/snapshot/nydus-proxy-mode=true into the snapshot labels for ro layers, and for the rw layer, we call mountWithKataVolume to set up mounts with proxy volume.

Therefore, the refined logic would be as follows on proxy driver: Verify whether the driver is proxy and the snapshot labels to ensure the inclusion of containerd.io/snapshot/nydus-proxy-mode=true. If this condition is met, proceed as usual; if not, return an error. Subsequently, prompt containerd to reprepare the snapshots for the image, even if the image's snapshots have been previously prepared by another snapshotter.
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix snapshot found when switching different snapshotter
f5c021a 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
609eac0 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
@ChengyuZhu6 ChengyuZhu6 mentioned this issue Apr 28, 2024
Merged
@ChengyuZhu6
Copy link
Contributor Author

I think the method maybe not perfect, but it could resolve the current issue.

ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
9295d6d 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
b9cb808 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
c1fbf56 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue Apr 28, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
5d0c74e 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
1ff7eb0 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
c09d940 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
3397ad5 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
a3921c4 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
5a32ecc 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
76c8880 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 10, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
437002b 
Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
@imeoer imeoer added the bug Something isn't working label May 10, 2024
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 11, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
11abf32 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 11, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
e0d1e74 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 11, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
e14a326 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 11, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
115a8ac 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
423f981 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
24bcdca 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
38d0d9f 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
fa24178 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
a27f916 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 14, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
6e06754 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 15, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
8a2c564 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 15, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
b5b72c5 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 15, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
b01f842 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6 added a commit to ChengyuZhu6/nydus-snapshotter that referenced this issue May 15, 2024
@ChengyuZhu6
snapshot: fix error on proxy driver when switching different snapshotter
8b98d6a 
During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
nydus snapshotter to let snapshotter prepare ro layers.
Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
and the logic of guest pull (proxy) is skipped.
This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.

Fixes: containerd#592

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@imeoer @ChengyuZhu6