Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bazil.org/fuse v0.0.0-20200407214033-5883e5a4b5125 #161

Merged
merged 1 commit into from Jul 23, 2021

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 17, 2020

rebased to include #159, as that removed quite a bit of vendor code

This will probably fail miserably on macOS, just noticed this change in the dependency, so opening as a quick draft. We could decide to pin to a more recent version, just before support was removed if macOS support is important, but may be living on borrowed time in case of compatibility issues with other dependencies.

full diff: bazil/fuse@371fbbd...5883e5a

This is the last commit before bazil/fuse@60eaf8f,
which removed support for macOS (see bazil/fuse#224)

Remove macOS support

OSXFUSE is no longer open source, see e.g.
https://colatkinson.site/macos/fuse/2019/09/29/osxfuse/

It looks like Apple is killing the whole category:
https://news.ycombinator.com/item?id=22251076

I will not personally put uncompensated effort into supporting
non-open source environments, especially ones that are this hostile to
work with. The macOS kludges were a significant amount of code, about
25% of the remaining non-test lines, and the primary source of
complexity and alternate code paths.

The API definitions will be remain for a short while, with deprecation
markers. This should let multiplatform callers work without changes.
Everything deprecated will be removed soon, so please adjust
your code.

@thaJeztah thaJeztah changed the title go.mod: bazil.org/fuse v0.0.0-20200524192727-fb710f7dfd05 go.mod: bazil.org/fuse v0.0.0-20200407214033-5883e5a4b5125 Sep 17, 2020
@thaJeztah thaJeztah force-pushed the update_fuse_2 branch 2 times, most recently from 3695bac to 932c6ad Compare March 13, 2021 17:36
full diff: bazil/fuse@371fbbd...5883e5a

This is the last commit before bazil/fuse@60eaf8f,
which removed support for macOS:

> Remove macOS support
>
> OSXFUSE is no longer open source, see e.g.
> https://colatkinson.site/macos/fuse/2019/09/29/osxfuse/
>
> It looks like Apple is killing the whole category:
> https://news.ycombinator.com/item?id=22251076
>
> I will not personally put uncompensated effort into supporting
> non-open source environments, especially ones that are this hostile to
> work with. The macOS kludges were a significant amount of code, about
> 25% of the remaining non-test lines, and the primary source of
> complexity and alternate code paths.
>
> The API definitions will be remain for a short while, with deprecation
> markers. This should let multiplatform callers work without changes.
> Everything deprecated will be removed soon, so please adjust
> your code.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review March 15, 2021 15:32
@thaJeztah
Copy link
Member Author

@AkihiroSuda ptal

@dmcgowan dmcgowan merged commit 8bdabd6 into containerd:main Jul 23, 2021
@thaJeztah thaJeztah deleted the update_fuse_2 branch July 24, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants