Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] adding support of CAP_BPF and CAP_PERFMON #7574

Merged

Conversation

swagatbora90
Copy link
Contributor

This PR is to cherry-pick #7301 "Adding support of CAP_BPF and CAP_PERFMON "

Signed-off-by: Henry Wang <henwang@amazon.com>
(cherry picked from commit 4390751)
Signed-off-by: Swagat Bora <sbora@amazon.com>
@k8s-ci-robot
Copy link

Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swagatbora90 swagatbora90 changed the title adding support of CAP_BPF and CAP_PERFMON [release/1.6] adding support of CAP_BPF and CAP_PERFMON Oct 22, 2022
@swagatbora90
Copy link
Contributor Author

swagatbora90 commented Oct 22, 2022

/cc @kzys

@samuelkarp
Copy link
Member

/ok-to-test

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's hold off on merging this until after 1.6.9.

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swagatbora90
Copy link
Contributor Author

swagatbora90 commented Oct 23, 2022

LGTM, but let's hold off on merging this until after 1.6.9

@samuelkarp thanks for cutting the new release. Will it be possible to get this change into 1.6.9?

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I think this is reasonable to pull into the 1.6.9 tag given it is part of us keeping up with the ecosystem/kernel features.

@dmcgowan
Copy link
Member

I think we can get this pulled in before cutting the release

@dmcgowan dmcgowan merged commit 96929a5 into containerd:release/1.6 Oct 24, 2022
@swagatbora90 swagatbora90 deleted the backport-cap-bpf-perfmon branch October 24, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants