Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] Do not append []string{""} to command to preserve Docker compatibility #7298

Merged
merged 1 commit into from Aug 16, 2022

Conversation

zuzzas
Copy link
Contributor

@zuzzas zuzzas commented Aug 16, 2022

Cherry-pick #6805

Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
(cherry picked from commit 5f3ce95)
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
@k8s-ci-robot
Copy link

Hi @zuzzas. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@zuzzas
Copy link
Contributor Author

zuzzas commented Aug 16, 2022

@dcantah
The failed test does not look related at all.

@samuelkarp
Copy link
Member

/ok-to-test

(Though I think the Prow job is having issues now)

@k8s-ci-robot
Copy link

@zuzzas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-node-e2e 0448673 link true /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zuzzas
Copy link
Contributor Author

zuzzas commented Aug 16, 2022

ServiceException: 409 A Cloud Storage bucket named 'cri-containerd-staging' already exists. Try another name. Bucket names must be globally unique across all Google Cloud projects, including those outside of your organization.

>_<

@samuelkarp
Copy link
Member

The Prow failure looks completely unrelated. I'm going to merge this anyway.

@samuelkarp samuelkarp merged commit 1be2cb3 into containerd:release/1.6 Aug 16, 2022
@zuzzas
Copy link
Contributor Author

zuzzas commented Aug 16, 2022

Thanks!

@zuzzas zuzzas deleted the docker-compat-1.6 branch August 16, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants