New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.6] Do not append []string{""} to command to preserve Docker compatibility #7298
[release/1.6] Do not append []string{""} to command to preserve Docker compatibility #7298
Conversation
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com> (cherry picked from commit 5f3ce95) Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
Hi @zuzzas. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI
@dcantah |
/ok-to-test (Though I think the Prow job is having issues now) |
@zuzzas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
>_< |
The Prow failure looks completely unrelated. I'm going to merge this anyway. |
Thanks! |
Cherry-pick #6805