Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[release/1.6] support fetching containerd from non public GCS buckets" #7830

Merged
merged 1 commit into from Dec 16, 2022
Merged

Revert "[release/1.6] support fetching containerd from non public GCS buckets" #7830

merged 1 commit into from Dec 16, 2022

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Dec 16, 2022 •
edited

Reverts #7823

The changes is causing continuous failure in containerd-node-e2e-1.6 and containerd-node-e2e-features-1.6, because the actual blob is not getting downloaded as per logs

@k8s-ci-robot
Copy link

Hi @akhilerm. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm
Revert "[release/1.6] support fetching containerd from non public GCS…
e8b22c1 
… buckets"

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm force-pushed the revert-7823-cherry-pick-7771-1.6 branch from 0b9a713 to e8b22c1 Compare December 16, 2022 17:08
@akhilerm
Copy link
Member Author

/cc @dmcgowan .

can you give an ok-to-test on the PR.

@estesp
Copy link
Member

estesp commented Dec 16, 2022

/ok-to-test

estesp
estesp approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 07b839d into containerd:release/1.6 Dec 16, 2022
@akhilerm akhilerm deleted the revert-7823-cherry-pick-7771-1.6 branch December 17, 2022 01:46
@dmcgowan dmcgowan mentioned this pull request Dec 19, 2022
Merged
@akhilerm akhilerm mentioned this pull request Jun 8, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhilerm @k8s-ci-robot @estesp @kzys