Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.6] support fetching containerd from non public GCS buckets #7823

Merged
merged 2 commits into from Dec 15, 2022

Conversation

akhilerm
Copy link
Member

cherry pick #7771 (not clean)

add support to fetch and download containerd tarball from GCS buckets that require authentication.
GCS_BUCKET_TOKEN should have read access to the bucket from which artifacts are to be fetched. The token is expected to be present in the instance metadata of the VM, similar to other node environment variables

To use this in tests from kubernetes, a new node env can be added as follows here. <your_gcs_bucket_token> can be fetched from a secret or from an env.

-node-env=GCS_BUCKET_TOKEN=<your_gcs_bucket_token>

- add support to fetch and download containerd tarball from GCS buckets
that require authentication.

GCS_BUCKET_TOKEN should have read access to the bucket from which
artifacts are to be fetched. The token is expected to be present in
the instance metadata of the VM, similar to other node environment
variables

Signed-off-by: Akhil Mohan <makhil@vmware.com>
(cherry picked from commit 9df96dc)
Signed-off-by: Akhil Mohan <makhil@vmware.com>
Signed-off-by: Akhil Mohan <makhil@vmware.com>
(cherry picked from commit b94c101)
Signed-off-by: Akhil Mohan <makhil@vmware.com>
@k8s-ci-robot
Copy link

Hi @akhilerm. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm
Copy link
Member Author

/cc @kzys @estesp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants