[release/1.6] allow client to remove created tasks with PID 0 #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containerd#7357 If a container is restored from a checkpoint that has a configuration error, the task for the restored container is created, but fails to start and is left in the state CREATED with a PID of 0. Before this change, the only way to remove this task was to find the PID of the shim monitoring the task and kill that process. Now, ctr t rm <task> will work on tasks that result in the CREATED state with PID 0. Signed-off-by: Gavin Inglis <giinglis@amazon.com> (cherry picked from commit 80839f1) Signed-off-by: Gavin Inglis <giinglis@amazon.com>
|
Hi @ginglis13. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dmcgowan
approved these changes
Dec 14, 2022
|
What do I need to do
…On Wed, Dec 14, 2022, 1:22 PM Derek McGowan ***@***.***> wrote:
Merged #7816 <#7816> into
release/1.6.
—
Reply to this email directly, view it on GitHub
<#7816 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3VMSHFHOSOO4OGCCQGQUBTWNIM7ZANCNFSM6AAAAAAS6VSQRE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick 80839f1
If a container is restored from a checkpoint that has a configuration error, the task for the restored container is created, but fails to start and is left in the state CREATED with a PID of 0. Before this change, the only way to remove this task was to find the PID of the shim monitoring the task and kill that process. Now, ctr t rm will work on tasks that result in the CREATED state with PID 0.
Signed-off-by: Gavin Inglis giinglis@amazon.com
(cherry picked from commit 80839f1)
Signed-off-by: Gavin Inglis giinglis@amazon.com